Skip to content
This repository has been archived by the owner on Apr 24, 2020. It is now read-only.

Remove TLS-SNI-02 challenge type and associated refs. #390

Merged
merged 4 commits into from Jan 23, 2018

Conversation

cpu
Copy link
Collaborator

@cpu cpu commented Jan 12, 2018

Recent developments[0] [1] [2] have identified real-world server/hosting
configurations that violate the assumptions of TLS-SNI-01 and its
currently specified replacement, TLS-SNI-02. In light of these issues
and the feasibility of addressing them across the entire Internet it
seems prudent that the ACME specification remove the affected
challenge type pending the development of a better alternative
(TLS-SNI-03?). This will allow the draft last-call to proceed while
the details of TLS-SNI-03 are worked out.

The "Default Virtual Hosts" sub-section of the "Operational
Considerations" section is removed since it spoke exclusively to
a concern with TLS-SNI-02 validation. When the dust has settled on
TLS-SNI-03 we should certainly include a section that describes why
TLS-SNI-01/02 were removed that could replace this information.

Recent developments[0][1] have identified real-world server/hosting
configurations that violate the assumptions of TLS-SNI-01 and its
currently specified replacement, TLS-SNI-02. In light of these issues
and the feasibility of addressing them across the entire Internet it
seems prudent that the ACME specification remove the vulnerable
challenge type pending the development of a better alternative
(TLS-SNI-03?). This will allow the draft last-call to proceed while
the details of TLS-SNI-03 are worked out.

The "Default Virtual Hosts" sub-section of the "Operational
Considerations" section is removed since it spoke exclusively to
a concern with TLS-SNI-02 validation. When the dust has settled on
TLS-SNI-03 we should certainly include a section that describes why
TLS-SNI-01/02 were removed that could replace this information.

[0]: https://community.letsencrypt.org/t/2018-01-09-issue-with-tls-sni-01-and-shared-hosting-infrastructure/49996
[1]: https://community.letsencrypt.org/t/2018-01-11-update-regarding-acme-tls-sni-and-shared-hosting-infrastructure/50188
@cpu cpu self-assigned this Jan 12, 2018
@cpu cpu requested review from bifurcation and jsha January 12, 2018 17:38
Ilari Liusvaara rightly points out that an HTTP-01 validation that is
redirected to port 443 may encounter an error that justifies the TLS
error type.
Copy link
Contributor

@kelunik kelunik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be any mention of tls-sni-02 that makes sure we use tls-sni-03 in a future RFC in case if gets re-added?

@cpu
Copy link
Collaborator Author

cpu commented Jan 15, 2018

Should there be any mention of tls-sni-02 that makes sure we use tls-sni-03 in a future RFC in case if gets re-added?

@kelunik I don't think we need a place-holder in-doc for this

Copy link
Contributor

@bifurcation bifurcation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ with the one comment addressed

@@ -2709,7 +2603,6 @@ Initial Contents
| Label | Identifier Type | ACME | Reference |
|:-----------|:----------------|:-----|:----------|
| http-01 | dns | Y | RFC XXXX |
| tls-sni-02 | dns | Y | RFC XXXX |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @kelunik that it would be good to have a tombstone here. The standard practice is to have a "reserved" entry in the registry, so that you don't conflict later, but you also don't define it. Here, I think the right row would be:

| tls-sni-02 | RESERVED | N | N/A |

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bifurcation Shouldn't there be one for tls-sni-01 by the same logic? Should I add both in this PR?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added both in 0bb71a0 - I can drop one if there's a reason we should only have a tombstone for tls-sni-02.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed OOB this addresses @bifurcation's comment.

@cpu cpu merged commit cfe1187 into ietf-wg-acme:master Jan 23, 2018
@cpu cpu deleted the cpu-tls-sni-02-we-hardly-knew-ye branch January 23, 2018 14:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants