This repository has been archived by the owner on Apr 24, 2020. It is now read-only.
Benjamin Kaduk's COMMENT feedback #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsha
approved these changes
Sep 14, 2018
cpu
commented
Sep 14, 2018
draft-ietf-acme-acme.md
Outdated
| @@ -370,7 +378,7 @@ ACME clients SHOULD send an Accept-Language header field in accordance with | |||
|
|
|||
| ACME servers that are intended to be generally accessible need to use | |||
| Cross-Origin Resource Sharing (CORS) in order to be accessible from | |||
| browser-based clients {{?W3C.CR-cors-20130129}}. Such servers SHOULD set the | |||
| browser-based clients {{?W3C.CR-cors-20140116}}. Such servers SHOULD set the | |||
There was a problem hiding this comment.
This is failing in CI:
*** 404 Not Found while fetching https://xml2rfc.tools.ietf.org/public/rfc/bibxml4/reference.W3C.CR-cors-20140116.xml
Suggestions from RFC wonks welcome. As best I can tell this is the correct way to be referencing this document: https://www.w3.org/TR/2014/REC-cors-20140116/
There was a problem hiding this comment.
Looks like this BibXML exists so {{?W3C.REC-cors-20140116}} should work.
There was a problem hiding this comment.
@bifurcation Thank you! Incorporated in 4d83965 - looks like it did the trick 🎉
bifurcation
approved these changes
Sep 18, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.