Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preliminary editorial. See #89. #90

Merged
merged 6 commits into from
Jul 6, 2022
Merged

Preliminary editorial. See #89. #90

merged 6 commits into from
Jul 6, 2022

Conversation

ioggstream
Copy link
Collaborator

This PR

  • editorial references (SELF, HTTP, STRUCTURED-FIELDS)
  • remove backticks
  • remove ABNF

@ioggstream ioggstream force-pushed the ioggstream-89 branch 2 times, most recently from a06e146 to 98929b8 Compare May 27, 2022 11:31
draft-ietf-httpapi-ratelimit-headers.md Outdated Show resolved Hide resolved
during a `time-window` as defined in {{time-window}}.

The `service-limit` is expressed in `quota-units` and has the following syntax:
during a [ time window](#time-window).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
during a [ time window](#time-window).
during a [time window](#time-window).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This space is a workaround for kramdowd, otherwise it will not render the string and just shows the section.

Comment on lines +205 to +207
and [ time-window](#time-window).
Its value is an Item
where the associated bare item is a [ service-limit](#service-limit) and parameters are supported.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
and [ time-window](#time-window).
Its value is an Item
where the associated bare item is a [ service-limit](#service-limit) and parameters are supported.
and [time-window](#time-window).
Its value is an Item
where the associated bare item is a [service-limit](#service-limit) and parameters are supported.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This space is a workaround for kramdown, otherwise it will not render the string and just shows the section.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cabo how can I force kramdown-rfc to treat time-window as a text string and not as a reference?

draft-ietf-httpapi-ratelimit-headers.md Outdated Show resolved Hide resolved
Comment on lines +417 to +418
the [ service-limit](#service-limit) associated to the client
in the current [ time-window](#time-window).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
the [ service-limit](#service-limit) associated to the client
in the current [ time-window](#time-window).
the [service-limit](#service-limit) associated to the client
in the current [time-window](#time-window).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This space is a workaround for kramdown, otherwise it will not render the string and just shows the section.


~~~ example
RateLimit-Policy: 100;w=10
RateLimit-Limit: 100
RateLimit-Limit: 100
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the extra whitespace?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to align with the response above. It is ok to remove though.

Co-authored-by: Alejandro Martinez Ruiz <alex@flawedcode.org>
@ioggstream ioggstream merged commit 3937a66 into main Jul 6, 2022
@ioggstream ioggstream deleted the ioggstream-89 branch July 6, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants