Add security considerations about injection attacks #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timbray
reviewed
Nov 17, 2022
| These variables need to be translated into the form they take in a | ||
| JSONPath query, e.g., by escaping string delimiters, or by only | ||
| allowing specific constructs such as `.name` to be formed when the | ||
| given values allow that. |
There was a problem hiding this comment.
Don't understand this point at all.
| values (e.g., by entering them into a Web form). | ||
| The resulting class of attacks, *injections* (e.g., SQL injections), | ||
| is consistently found among the top causes of application security | ||
| vulnerabilities and requires particular attention. |
There was a problem hiding this comment.
Would be improved by examples?
There was a problem hiding this comment.
I am reluctant here. Examples might be used as starting point for potential attackers.
There was a problem hiding this comment.
@goessner I understand your reluctance, but the examples are likely to be simple attacks which anyone with the relevant background (attackers, penetration testers, etc.) would think of immediately.
glyn
reviewed
Nov 17, 2022
|
We wanted to add examples, but maybe we can merge this as is. Marking as ready for review. |
glyn
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.