Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User interaction #448

Closed
martinthomson opened this issue Aug 30, 2023 · 2 comments · Fixed by #474
Closed

User interaction #448

martinthomson opened this issue Aug 30, 2023 · 2 comments · Fixed by #474
Assignees

Comments

@martinthomson
Copy link
Contributor

I have a lot to say about this section, but let's start with the big one:

Token challenges can be performed without explicit user involvement, depending on the issuance protocol.

That's at best misleading. There are multiple factors that might cause a client to supply a token without user involvement, but the choice of protocol is not something that is relevant. Sure, there might be cases where something makes user involvement necessary, but this is not the overriding concern.

The main concern is that the token carries information from one context to another and the Web generally tries to avoid that happening without very good reason. In order to overcome that, most clients/user agents will want to ensure that a number of conditions are met.

We don't need to go into those conditions here, because this is an IETF specification. In fact, most of this section doesn't belong in an IETF specification as it relates to decisions that web user agents might choose to make. In other contexts, the considerations are different and so different constraints might be appropriate.

I'll go further and say that while this specification is clearly designed for the Web, it is not fit for that purpose.

What this document needs is a section explaining how a client might choose to use tokens, what the risks involved are, and how those risks might be mitigated. Some of that is probably already in the architecture document, but this document makes a lot of that quite concrete. A brief overview of the challenges that is backed by references to the architecture is probably worthwhile.

@paulwouters
Copy link

@martinthomson does this resolve your issue ?

@martinthomson
Copy link
Contributor Author

Yes, this is much better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants