Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for double-click detection, added helper method to get lays index based on y coordinate. #8

Closed
wants to merge 2 commits into from

Conversation

artifacts
Copy link
Contributor

No description provided.

…triple clicks after a double-click (e.g. add a kf via double click then quickly move the lane within the double click-interval)

- Added helper method to get the lane index based the y coordinate
@ievgennaida
Copy link
Owner

ievgennaida commented May 7, 2020

Hello,
Thanks for your input.
The codebase is refactored and more changes are coming,
so this one cannot be merged.

click fix is reimplemented but I don't like the idea to get index by a coordinate.
My proposal is to get row by a coordinate, then you can find an index.
Also, your model can include an index.

There is a new method elementFromPoint. It can be used to get elements under the mouse. The row can be filtered by type than.

P.s. mouse events will give you all clicked elements so it might be that this method will be obsolete.

@ievgennaida
Copy link
Owner

Refactoring is started, there are few things left to do, but this one is reimplemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants