Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't tab out out of InputTextarea into the next input field #1084

Closed
julianguyen opened this issue Oct 3, 2018 · 14 comments
Closed

Can't tab out out of InputTextarea into the next input field #1084

julianguyen opened this issue Oct 3, 2018 · 14 comments

Comments

@julianguyen
Copy link
Member

Description

Can't tab out out of InputTextarea into the next input field

Reproduction Steps

From /moments/new or /strategies/new, try to tab into the input fields instead of clicking into them. You'll notice that you can tab into the WYSIWYG editor, but you can't tab out of it.

Screenshots

capture

Do you want to be the assignee to work on this?

🚫

@simonhoyos
Copy link

I can work on this one

@julianguyen
Copy link
Member Author

@shmesa22 Thanks for expressing your interest. Please check out https://github.com/ifmeorg/ifme/wiki/Join-Our-Slack for next steps. After that, assign yourself to the issue.

@arku
Copy link
Contributor

arku commented Oct 8, 2018

I am going to assign myself to this issue as there hasn't been any response from @shmesa22

@member-cop
Copy link

member-cop bot commented Oct 8, 2018

Hey @arun1595, thanks for expressing your interest. We would love your help with this issue. Please follow these next steps to join our contributor community.

@arku arku self-assigned this Oct 8, 2018
@ifmeorg ifmeorg deleted a comment from member-cop bot Oct 8, 2018
@arku
Copy link
Contributor

arku commented Oct 11, 2018

Update: I haven't been able to figure out the issue yet. Will try to do some reading on how tabindex works on non-interactive elements and see if it helps resolving this issue.

@julianguyen
Copy link
Member Author

@arun1595 Thnks for posting an update! You might have to set up a listener to watch for a tab key press in that element. Let us know on Slack if you need any more help :)

@geppy
Copy link
Contributor

geppy commented Oct 21, 2018

@arun1595 This is caused by a bug in Pell. It's canceling 'Tab' keydown events, which it shouldn't be doing.

We could fork Pell and fix that bug, or use another editor.

@geppy
Copy link
Contributor

geppy commented Oct 22, 2018

I sent a PR fixing this bug in pell.

@julianguyen
Copy link
Member Author

julianguyen commented Oct 27, 2018

Woo awesome catch/fix @geppy! I think we should wait till your PR is merged. Pell is really nice and lightweight, so I'd like to stick with it.

@arku
Copy link
Contributor

arku commented Oct 29, 2018

Nice catch @geppy 🎉

@arku arku removed their assignment Oct 29, 2018
@LMulvey
Copy link
Contributor

LMulvey commented Dec 3, 2018

I've reached out to the developer of Pell to see if he'd allow other contributors to the project (I offered a bit of my time) so at the very least the outstanding PRs can be reviewed/merged. He seems to be based quite close to me so I'll meet up with him if need be, especially in light of the event-stream shenanigans last week.

Update: Got a response from Jared–he said that he'll jump on the PRs later this week 😄

@jaredreich
Copy link

jaredreich commented Dec 5, 2018

Hey everyone, please see pell v1.0.6. Sorry for the delay. Nice work with this project.
@LMulvey @geppy @julianguyen

@LMulvey
Copy link
Contributor

LMulvey commented Dec 6, 2018

Thanks @jaredreich !

@julianguyen
Copy link
Member Author

Feel free to file a PR updating the Pell version @geppy! :D

Thank you for fixing it, it's gonna benefit so many people 🎉 Thanks @LMulvey for inquiring :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants