create missing tests for groups form helper #1470

scw248 · 2019-05-03T20:14:09Z

Description

I used the the form_helper_spec to model the groups_form_helper_spec file that I created. Tested that inputs are valid.

Corresponding Issue

#1408

Screenshots

Test Coverage

I apologize, but I'm not sure I understand what this field means.

✅
🚫

@julianguyen, could you let me know if I'm on the right track with this pr? I know there are probably a few details that I'm missing.

welcome · 2019-05-03T20:14:12Z

Thank you for opening this pull request with us! Be sure to follow our Pull Request Practices. Let us know if you have any questions on Slack.

julianguyen

Good start! Thanks for taking the time to write tests :)

Left some feedback - let me know if there's any further questions! Awesome work!

spec/helpers/groups/form_helper_spec.rb

scw248 · 2019-05-04T18:52:37Z

Hi, @julianguyen, thank you for the feedback! I apologize for what is probably a dumb question, but I've never edited a pr before. How would I update my pull with any other pr's submitted in the last 24 hours so my branch is up to date, and then make your recommended changes to sync them back up to my pr?

julianguyen · 2019-05-04T19:04:15Z

@scw248 Not a dumb question at all! So we've documented our recommended git workflow! You'll want to sync your fork to this repository. To update your PR with your changes, simply create more commits on top of the existing ones!

If you need any more help, let's sync on Slack! :)

scw248 · 2019-05-04T20:31:12Z

@julianguyen thank you!

scw248 · 2019-05-10T19:19:53Z

@julianguyen, I believe I made all of the corrections properly as far as adding an extra 'end', removing white space, removing unnecessary variables, and replacing the inputs with concrete values. Could you please take a look at my updated commit?

scw248 · 2019-05-24T15:55:51Z

Hi @julianguyen, I just pushed a new set of code, but the circleci error seems to be with a different folder than what I'm working on: app/components/Story/index.jsx:30:16. Could you clarify if this is an error on my end or if this was an error from someone else's pr?

julianguyen · 2019-05-25T19:48:49Z

@scw248 You're correct, looks like a bug was introduced! I just merged in a fix for it!
Can you rebase from master?

julianguyen

Awesome work! Thanks 🎉

julianguyen

I ran your tests locally and it's actually failing. Please run rpec locally and do not rely on CircleCI to run your tests.

spec/helpers/groups/form_helper_spec.rb

scw248 · 2019-05-27T21:29:34Z

@julianguyen Thank you for your help! I just committed again and have some additional issues with my code I'm working on.

I tried running rspec after bundle install, but I kept getting this error: ActiveRecord::NoDatabaseError: FATAL: database "ifme_test" does not exist. I'll keep working on it, but didn't want you to think I wasn't following your suggestions!

julianguyen · 2019-05-27T23:44:38Z

@scw248 What happens when you run bin/rake db:setup db:test:prepare?

scw248 · 2019-05-31T15:31:48Z

@julianguyen, sorry for the delay. When I run the bin/rake... it loads the tables correctly, but then when I run rspec afterwards, I get this error:

React on Rails FATAL ERROR! Error in building webpack assets! cmd: cd "client" && yarn build:test exitstatus: 127 stderr: sh: yarn: command not found

It looks like the response of user: nqthqn on the below github issue might solve it, but let me know if you suggest I try something else.

webpack/webpack#2131

julianguyen · 2019-05-31T23:00:30Z

@scw248 It looks like yarn is not found, can you install yarn? You can do so by following these steps. Hope that helps!

scw248 · 2019-06-01T19:50:05Z

Thanks @julianguyen. I downloaded yarn and ran it, but am now getting engine 'node' incompatibilities. I apologize for all of the back and forth, but could you let me know if you have any time to connect on slack this week?

scw248 · 2019-06-07T20:47:23Z

Hi @julianguyen, so I've figured out why yarn wasn't building and had to update some node packages. I am down to two specs being incorrect, and they're for the same thing:

` 1) GroupsFormHelper#new_group_props has invalid arguments returns nil
Failure/Error: expect(subject).to eq(nil)

   expected: nil
        got: {:action=>"/groups", :inputs=>[{:dark=>true, :id=>"group_name", :label=>"Name", :name=>"group[name]",...ea", :value=>"Group description"}, {:dark=>true, :id=>"submit", :type=>"submit", :value=>"Submit"}]}
 
   (compared using ==)
 # ./spec/helpers/groups/form_helper_spec.rb:40:in `block (4 levels) in <top (required)>'

`

I can't quite seem to figure out why the test is running my valid_inputs and not catching nil. I'm going to submit my updated code now, but could you take a look?

julianguyen · 2019-07-09T19:38:19Z

Hey @scw248 let's pair program on this! Let's coordinate on Slack when to do so :D

scw248 · 2019-07-13T18:20:51Z

Hey @julianguyen, it looks like CircleCi is coming up with an error that is not appearing when I run Rspec locally. It appears to have a problem with what we changed the action name to as well as the value.

Is this something that should be updated with CircleCi? Happy to work on it further locally if needed

julianguyen · 2019-07-15T16:40:27Z

spec/helpers/groups/form_helper_spec.rb

+      end
+    end
+
+    describe '#edit_group_props' do


I think the test is failing cause of how we nested these tests. If you look at the CircleCI failure you'll see the test reads as #new_group_props #edit_group_props has invalid arguments returns correct props. We need to move this describe block to level above.

Ahh gotcha, corrected! It looks like the CircleCi issue now is with the OmniAuth gem. It's suggesting that it be disabled until patch is available. Wane me to disable it?

Oh :O We don't want to disable it though since it's needed for authentication.

How did you figure out it was an issue with this gem? Is there a page you can link me to?

Oh, no worries! I just saw it in the audit check if you scroll down in CircleCi: https://circleci.com/gh/ifmeorg/ifme/8697?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

Ahh, that is a valid issue. I'll merge your tests since they pass! I'll take care of the gem vulnerability issue, thanks for calling it out!

julianguyen

Awesome work! Thank you for writing these tests!

welcome · 2019-07-15T22:46:52Z

Thank you for merging this pull request with us! If you haven't already, in another pull request, please add yourself to our Contribute page.

scw248 · 2019-07-15T23:51:36Z

@julianguyen Thank you very much for the opportunity, and your help! I look forward to contributing more soon!

julianguyen requested changes May 4, 2019

View reviewed changes

julianguyen approved these changes May 25, 2019

View reviewed changes

julianguyen requested changes May 25, 2019

View reviewed changes

spec/helpers/groups/form_helper_spec.rb Outdated Show resolved Hide resolved

spec/helpers/groups/form_helper_spec.rb Outdated Show resolved Hide resolved

julianguyen reviewed May 25, 2019

View reviewed changes

spec/helpers/groups/form_helper_spec.rb Outdated Show resolved Hide resolved

scw248 added 7 commits July 11, 2019 15:51

create missing tests for groups form helper

993d3f9

fix nil variables, missing end, and extra whitespace

52ce6bd

updated inputs with concrete values

374e18d

fixed syntax errors on groups/form_helper

5ac36e3

added inputs/action variables back in so args work

e75f305

mocked out @group and updated params

26cb154

updated valid_inputs for new and edit form props

8338ba6

scw248 force-pushed the add-tests-group-forms-helper branch from efbb224 to 8338ba6 Compare July 11, 2019 20:55

scw248 added 4 commits July 11, 2019 16:24

work in progress to test @group with try()

37f0243

corrected new group inputs for nil

32bbc80

removed unnecessary tests and corrected edit form helper tests

68b5db0

changed .try in common inputs to &. for safer testing

ac05e4e

julianguyen reviewed Jul 15, 2019

View reviewed changes

corrected spec back to groups_form_helper_spec.rb

b57fad7

julianguyen approved these changes Jul 15, 2019

View reviewed changes

julianguyen merged commit 600ba4c into ifmeorg:master Jul 15, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

create missing tests for groups form helper #1470

create missing tests for groups form helper #1470

scw248 commented May 3, 2019

welcome bot commented May 3, 2019

julianguyen left a comment

scw248 commented May 4, 2019

julianguyen commented May 4, 2019

scw248 commented May 4, 2019

scw248 commented May 10, 2019

scw248 commented May 24, 2019

julianguyen commented May 25, 2019 •

edited

Loading

julianguyen left a comment

julianguyen left a comment

scw248 commented May 27, 2019

julianguyen commented May 27, 2019

scw248 commented May 31, 2019 •

edited

Loading

julianguyen commented May 31, 2019

scw248 commented Jun 1, 2019

scw248 commented Jun 7, 2019

julianguyen commented Jul 9, 2019

scw248 commented Jul 13, 2019

julianguyen Jul 15, 2019

scw248 Jul 15, 2019

julianguyen Jul 15, 2019

scw248 Jul 15, 2019

julianguyen Jul 15, 2019

julianguyen left a comment

welcome bot commented Jul 15, 2019

scw248 commented Jul 15, 2019

create missing tests for groups form helper #1470

create missing tests for groups form helper #1470

Conversation

scw248 commented May 3, 2019

Description

Corresponding Issue

Screenshots

Test Coverage

welcome bot commented May 3, 2019

julianguyen left a comment

Choose a reason for hiding this comment

scw248 commented May 4, 2019

julianguyen commented May 4, 2019

scw248 commented May 4, 2019

scw248 commented May 10, 2019

scw248 commented May 24, 2019

julianguyen commented May 25, 2019 • edited Loading

julianguyen left a comment

Choose a reason for hiding this comment

julianguyen left a comment

Choose a reason for hiding this comment

scw248 commented May 27, 2019

julianguyen commented May 27, 2019

scw248 commented May 31, 2019 • edited Loading

julianguyen commented May 31, 2019

scw248 commented Jun 1, 2019

scw248 commented Jun 7, 2019

julianguyen commented Jul 9, 2019

scw248 commented Jul 13, 2019

julianguyen Jul 15, 2019

Choose a reason for hiding this comment

scw248 Jul 15, 2019

Choose a reason for hiding this comment

julianguyen Jul 15, 2019

Choose a reason for hiding this comment

scw248 Jul 15, 2019

Choose a reason for hiding this comment

julianguyen Jul 15, 2019

Choose a reason for hiding this comment

julianguyen left a comment

Choose a reason for hiding this comment

welcome bot commented Jul 15, 2019

scw248 commented Jul 15, 2019

julianguyen commented May 25, 2019 •

edited

Loading

scw248 commented May 31, 2019 •

edited

Loading