Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor perfomance improvement #2025

Merged
merged 8 commits into from
Oct 13, 2021
Merged

Minor perfomance improvement #2025

merged 8 commits into from
Oct 13, 2021

Conversation

rahmatullah5
Copy link
Member

Description

Add some minor improvement.

More Details

Add minor improvement based on rubocop reviews.

Corresponding Issue

Screenshots

Reviewing this pull request? Check out our Code Review Practices guide if you haven't already!

@rahmatullah5 rahmatullah5 self-assigned this Oct 11, 2021
@rahmatullah5
Copy link
Member Author

@julianguyen I have updated the code, please kindly check it.

Thanks

@rahmatullah5 rahmatullah5 requested review from brunoocasali and removed request for 256hz October 11, 2021 08:43
@brunoocasali
Copy link
Member

Thanks for your PR! 👍

brunoocasali
brunoocasali requested changes Oct 11, 2021
View reviewed changes
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, I suggest you to squash your commits into one or two :)

@rahmatullah5
Copy link
Member Author

Left some comments, I suggest you to squash your commits into one or two :)

Isn't it we can squash the commits when merge? CMIIW

julianguyen
julianguyen approved these changes Oct 13, 2021
View reviewed changes
Copy link
Member

@julianguyen julianguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these improvements! I don't know if these are truly performance improvements, but they're definitely style ones which is important!

@julianguyen julianguyen merged commit f479119 into main Oct 13, 2021
@delete-merged-branch delete-merged-branch bot deleted the minor-perfomance-improvement branch October 13, 2021 20:01
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianguyen julianguyen julianguyen approved these changes

@cpretzer cpretzer Awaiting requested review from cpretzer

@yasirazgar yasirazgar Awaiting requested review from yasirazgar

@seannemann21 seannemann21 Awaiting requested review from seannemann21

@3minus1 3minus1 Awaiting requested review from 3minus1

@abrophy abrophy Awaiting requested review from abrophy

@aditya20t aditya20t Awaiting requested review from aditya20t

@adamjpena adamjpena Awaiting requested review from adamjpena

@adang48 adang48 Awaiting requested review from adang48

@adorgan adorgan Awaiting requested review from adorgan

@aelydens aelydens Awaiting requested review from aelydens

@ajquintero ajquintero Awaiting requested review from ajquintero

@brunoocasali brunoocasali Awaiting requested review from brunoocasali

Assignees

@rahmatullah5 rahmatullah5

Labels
accessibility hacktoberfest performance refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rahmatullah5 @brunoocasali @julianguyen