2143 - display bookmarked moments in care plan #2154
Conversation
app/javascript/packs/application.js
Outdated
| @@ -0,0 +1,18 @@ | |||
| /* eslint no-console:0 */ | |||
There was a problem hiding this comment.
Let's delete this file since it's not necessary!
config/webpack/development.js
Outdated
| @@ -0,0 +1,5 @@ | |||
| process.env.NODE_ENV = process.env.NODE_ENV || 'development' | |||
There was a problem hiding this comment.
Let's also remove this file!
config/webpack/environment.js
Outdated
| @@ -0,0 +1,3 @@ | |||
| const { environment } = require('@rails/webpacker') | |||
There was a problem hiding this comment.
Let's also remove this file!
config/webpack/production.js
Outdated
| @@ -0,0 +1,5 @@ | |||
| process.env.NODE_ENV = process.env.NODE_ENV || 'production' | |||
There was a problem hiding this comment.
Let's also remove this file!
config/webpack/test.js
Outdated
| @@ -0,0 +1,5 @@ | |||
| process.env.NODE_ENV = process.env.NODE_ENV || 'development' | |||
There was a problem hiding this comment.
Let's also remove this file!
spec/requests/care_plan_spec.rb
Outdated
| @@ -19,6 +19,17 @@ | |||
| expect(response.body).to include(strategy.name) | |||
| end | |||
| end | |||
|
|
|||
| context 'when there are bookmarked moments' do | |||
| let!(:strategy_bm) { create(:strategy, user: user, bookmarked: true) } | |||
There was a problem hiding this comment.
This test should replace the strategy variables with moment ones!
|
@julianguyen I have addressed your feedbacks, apologies added some generated files by mistake, removed them now. |
app/helpers/moments_form_helper.rb
Outdated
| @@ -87,7 +87,8 @@ def moment_bookmarked | |||
| 'bookmarked', 'switch', 'moments.form.bookmarked_question' | |||
| ).merge( | |||
| value: true, uncheckedValue: false, | |||
| checked: @moment.bookmarked, dark: true | |||
| checked: @moment.bookmarked, dark: true, | |||
There was a problem hiding this comment.
checked: @moment.bookmarked should be checked: params[:bookmarked] ? true : @moment.bookmarked so that when you create a Moment from the Care Plan page, it will automatically be bookmarked.
There was a problem hiding this comment.
Yeah gotcha, updated now.
Description
Enable ability to bookmark Moments and display them on the Care Plan page
More Details
Corresponding Issue
#2143
Screenshots
Reviewing this pull request? Check out our Code Review Practices guide if you haven't already!