2149 - add canvas mock #2167
Merged
2149 - add canvas mock #2167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianguyen
requested changes
Oct 11, 2022
| @@ -10060,6 +10065,14 @@ iterate-value@^1.0.2: | |||
| es-get-iterator "^1.0.2" | |||
| iterate-iterator "^1.0.1" | |||
|
|
|||
| jest-canvas-mock@^2.4.0: | |||
There was a problem hiding this comment.
I think we should be explicitly including jest-canvas-mock in our package.json.
There was a problem hiding this comment.
I have added jest-canvas-mock to package.json, I believe we still need this change as well, right ?
| @@ -2,6 +2,7 @@ | |||
| import React from 'react'; | |||
| import { render } from '@testing-library/react'; | |||
| import { Chart } from 'components/Chart/index'; | |||
| import 'jest-canvas-mock'; | |||
There was a problem hiding this comment.
ESLint raised an import/no-unresolved error. If you run yarn lint:eslint locally you should see that error. While we could make this an exception, I think a better solution would be to include this in our Jest setup.
Check out the docs for this depedendency on how to do that.
We'll want to add here in our /client/package.json file.
There was a problem hiding this comment.
fixed the dependencies.
julianguyen
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added canvas mock package to fix Chart.spec.jsx
Reference: hustcc/jest-canvas-mock#2
Corresponding Issue
#2149
Screenshots
Reviewing this pull request? Check out our Code Review Practices guide if you haven't already!