Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Certain elements lack dark mode colors #394

Closed
Keltena opened this issue Jul 12, 2024 · 2 comments · Fixed by #400 or #405
Closed

Certain elements lack dark mode colors #394

Keltena opened this issue Jul 12, 2024 · 2 comments · Fixed by #400 or #405
Labels
light/dark mode

Comments

@Keltena
Copy link
Contributor

Keltena commented Jul 12, 2024

ifcomp.css doesn't specify dark mode styles for code or .alert-danger, so they appear in light mode colors:

A paragraph in dark mode colors, with a sentence in red fixed-width text on a very light pink background
"Login failed" alert on a very light pink background that clashes with the dark theme's pale blue hyperlink color

(Using Firefox 128.0 on Windows 10.)
@Keltena
Copy link
Contributor Author

Keltena commented Jul 22, 2024

Same problem with .breadcrumb:
In dark mode, the "Your entries / Register a new entry" header is pale gray with dark gray text

All buttons are also using light mode colors (although some cases are less obvious due to background-color being accidentally overridden).

@Keltena
Copy link
Contributor Author

Keltena commented Jul 24, 2024

Also .alert-success:
Dark mode screenshot with a pale green alert box confirming that "You have withdrawn the entry titled x."

Keltena added a commit to Keltena/ifcomp that referenced this issue Jul 29, 2024
@Keltena
Add comments to note missing dark-mode colors.
484a708 
(See iftechfoundation#394: Certain elements lack dark mode colors)
@Keltena Keltena mentioned this issue Jul 29, 2024
Merged
mjmusante pushed a commit that referenced this issue Aug 1, 2024
@Keltena @mjmusante
Add comments to note missing dark-mode colors.
5767715 
(See #394: Certain elements lack dark mode colors)
@Keltena Keltena mentioned this issue Aug 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
light/dark mode
Projects
None yet
Milestone
No milestone
2 participants
@curiousdannii @Keltena