Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Quixe interpreter #117

Merged
merged 35 commits into from
Aug 2, 2017
Merged

Add Quixe interpreter #117

merged 35 commits into from
Aug 2, 2017

Conversation

jmacdotorg
Copy link
Member

This adds the Quixe interpreter, version 2.1.6, to the project. Consequently, it removes the Glulx-compatible Parchment files from the project (while preserving Parchment for use with Z-code games).

Uploaded Glulx-based games that don't themselves provide a Quixe interpreter will use ours. It doesn't make use of Quixe's native transcript recording, but I intend to add this in a future (pre-October) update.

This patch also improves and clarifies the contents of root/static/interpreter, putting everything into three neat subdirectories (for parchment, quixe, and the transcript recorder), instead of its current muddle.

Addresses #66.

@taskboy3000
Copy link
Collaborator

For what it's worth, you might consider refactoring the way the base HTML file for quixe is generated. You can make a controller smart enough to generate this HTML and save it to the right place. That is the Railsy way to handle this.

When creating content dir for quixe games, use our locally-installed Quixe interpreter.
…t script.

Getting rid of the bogus contents of the test games' "main" directories, replacing them with files that are processed as expected into their respective "content" direcories.
@jmacdotorg
Copy link
Member Author

@taskboy3000, I get you, but I want this to work outside of the web application per se. In other words, I want to (and often do) call a script that re-generates the pages in question, as needed. I'd rather not have to artificially hit the website via script to have the same effect.

Copy link
Member

@adherzog adherzog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, though I haven't really dug into the details. I'm not particularly up on the various interpreters and how that all works.

This does feel like the kind of work that should be put on the dev/staging/test (I dunno what you call it) server and tested out there for a bit before merging, though. But I'll defer to the rest of y'all on that.

@coveralls
Copy link

coveralls commented Jul 26, 2017

Coverage Status

Coverage decreased (-0.6%) to 46.123% when pulling cbba5a7 on quixe into e246e87 on master.

@coveralls
Copy link

coveralls commented Jul 27, 2017

Coverage Status

Coverage increased (+7.4%) to 54.203% when pulling c9f9833 on quixe into e246e87 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+7.5%) to 54.443% when pulling c77c4f1 on quixe into 0a7618b on master.

@adherzog adherzog changed the base branch from master to dev July 29, 2017 16:09
@adherzog adherzog changed the base branch from dev to master July 29, 2017 16:36
@coveralls
Copy link

Coverage Status

Coverage increased (+10.06%) to 57.007% when pulling b46bf9f on quixe into b6d1464 on master.

It also removes the restriction of displaying transcript links only during the judging period. In this way, authors can test their own games' transcription powers prior to judging, and why not?
This extends transcription visibility to quixe games.
@coveralls
Copy link

Coverage Status

Coverage increased (+10.3%) to 57.222% when pulling 06535c1 on quixe into b6d1464 on master.

@curiousdannii
Copy link
Member

The version of Parchment in this branch is extremely old, and probably somewhat buggy. Why was zvm.min.js deleted?

@jmacdotorg
Copy link
Member Author

jmacdotorg commented Aug 2, 2017

@curiousdannii: Could you please open a new issue with your recommendation for which commit or branch of Parchment to use for Z-code games? I'd love to update IFComp's copy.

As to your question... well, it's a good question. I don't consciously remember deleting zvm.min.js, so it may have been an oversight on my part while I rearranged IFComp's interpreter files. That said, it looks like that file is (at least in the version IFComp uses) invoked only by parchment.debug.js, which in turn is not invoked by anything?

@curiousdannii curiousdannii mentioned this pull request Aug 2, 2017
7 tasks
@jmacdotorg jmacdotorg merged commit 06535c1 into master Aug 2, 2017
@jmacdotorg jmacdotorg deleted the quixe branch August 2, 2017 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants