Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches the IFDB dev environment to MariaDB 10. It seemed to work when I smoke tested it.
Note that IFDB does not work with the current latest MySQL 8, which uses ICU regular expressions instead of MySQL 5 "Henry Spencer" regexes. https://dev.mysql.com/doc/refman/8.0/en/regexp.html#regexp-compatibility
For example, if you just change the
mysql
line indocker-compose.yml
tomysql:8
, searches by author failhttp://localhost:8080/search?searchfor=author%3AEmily+Short
because the query includes this "Henry Spencer" regex:author like '%Emily Short%' or author rlike '[[:<:]]E.*[[:space:]]+Short[[:>:]]'
I did confirm that search by author works as expected in MariaDB 10, but I think without a clear test plan, it's hard to be sure whether this is safe.