Form validation #14
Form validation #14
Conversation
There was a problem hiding this comment.
Hi @ifzyy and @alanluqman ,
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉 🎉 🎉
Highlights
✔️ No linter errors
✔️ Git flow was correctly used
✔️ Good design
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| const email = emailElement.value.trim(); | ||
| if (!emailValid(email)) { | ||
| document.querySelector('#error').innerHTML = '* Please enter a valid email.'; |
There was a problem hiding this comment.
- [optional] It would be nice to rewrite the error message to be more clear on the issue of why the email s not valid.
Form validation