Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hillshades from non-activated basemaps can be turned on #231

Closed
Zalitoar opened this issue Aug 29, 2023 · 2 comments
Closed

Hillshades from non-activated basemaps can be turned on #231

Zalitoar opened this issue Aug 29, 2023 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Zalitoar
Copy link
Member

Problem:
Now, other hillshades layers can be turned on, messing with the layer z order leaving shadows layer behind the basemap and its state will mismatch the state of its switch because it was changed before the basemap was selected.

Expected behavior:
Only the active basemap hillshades switch must be enabled.

@Zalitoar Zalitoar added the bug Something isn't working label Aug 29, 2023
@Zalitoar Zalitoar added this to the v1.5.2 milestone Aug 29, 2023
@Zalitoar Zalitoar self-assigned this Aug 29, 2023
@Zalitoar Zalitoar modified the milestone: v1.5.2 Aug 31, 2023
@Zalitoar Zalitoar removed their assignment Dec 11, 2023
@Zalitoar Zalitoar modified the milestones: v1.5.2, v1.5.4 Dec 22, 2023
@InMunken InMunken self-assigned this Jan 12, 2024
@InMunken
Copy link
Contributor

#4ecfe35 Only the active basemap have hillshades switch are be enabled.

@InMunken
Copy link
Contributor

Problem:
When clicking the basemap item, the basemap reloads, so if hillshade was active it is left behind the basemap, making it not visible.

Expected behavior:
Clicking an already active basemap should not reload the basemap on top of the hillshade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants