Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api,monitor): npm vulnerabilities #277

Merged
merged 1 commit into from
Feb 11, 2022
Merged

fix(api,monitor): npm vulnerabilities #277

merged 1 commit into from
Feb 11, 2022

Conversation

amrosu
Copy link
Collaborator

@amrosu amrosu commented Feb 11, 2022

Correction des vulnérabilités npm :

  • pour l'API, on avait 4 vulnérabilités (1 modérée et 3 majeures) et maintenant il reste une vulnérabilité majeure liée à node-fetch, dépendance de node-pre-gyp - correction en cours du côté node-pre-gyp et donc pas encore disponible
  • pour itowns, on avait 3 vulnérabilités (2 mineures et 1 modérée) - toutes corrigées

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1828680099

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.159%

Totals Coverage Status
Change from base Build 1824363479: 0.0%
Covered Lines: 5039
Relevant Lines: 5338

💛 - Coveralls

Copy link
Collaborator

@nlenglet-ign nlenglet-ign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je confirme que toutes les vulnérabilités ont été corrigés sur la partie itowns.
Il reste bien une vulnérabilité majeure sur la partie API comme indiqué (qui concerne bien node-fetch - node-pre-gyp).

@amrosu amrosu merged commit 15bac1d into master Feb 11, 2022
@amrosu amrosu deleted the fix_vuln_npm branch April 21, 2022 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants