Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Now Playing #7

Closed
7 of 8 tasks
Tracked by #6
ignaciosica opened this issue Jan 3, 2023 · 0 comments · Fixed by #8 or #18
Closed
7 of 8 tasks
Tracked by #6

Refactor Now Playing #7

ignaciosica opened this issue Jan 3, 2023 · 0 comments · Fixed by #8 or #18
Assignees
@ignaciosica
Milestone
mvp launch

Comments

@ignaciosica
Copy link
Owner

ignaciosica commented Jan 3, 2023 •
edited
Loading

  • Implement new design
  • Improve widget reliability
  • Fix inner padding
  • Progress indicator updates automatically
  • While loading, display dummy widget
  • While loading, progress indicator displays loading state
  • Show reconnect button to manually reconnect if connection is lost
  • Connect to spotify on widget init
@ignaciosica ignaciosica self-assigned this Jan 3, 2023
@ignaciosica ignaciosica mentioned this issue Jan 3, 2023
Closed
1 task
ignaciosica pushed a commit that referenced this issue Jan 5, 2023
[#7] Starting over with widget
6c7d798
ignaciosica pushed a commit that referenced this issue Jan 5, 2023
[#7] refactor now playing widget root
13eaa4a
ignaciosica pushed a commit that referenced this issue Jan 5, 2023
[#7] moved every subwidget to different file
5f31419
ignaciosica pushed a commit that referenced this issue Jan 5, 2023
[#7] rename widgets and removed unused code
d73feaf
ignaciosica added a commit that referenced this issue Jan 5, 2023
@ignaciosica
[#7] change now playing widget
7241b95
@ignaciosica ignaciosica linked a pull request Jan 5, 2023 that will close this issue
Refactor now playing #8
Merged
ignaciosica pushed a commit that referenced this issue Jan 5, 2023
[#7] progress with refactor
953cb76 
- fixed songProgressIndicatorDummy
- removed initialization of stream from initState in nowPlaying widget
- changed timer duration from 6 to 4s in nowPlayingDummy
- changed nowPlayingDummy to look like wid
- progress with nowPlayingWid
- changed appbar background color to gradient
ignaciosica pushed a commit that referenced this issue Jan 5, 2023
[#7] progress with songProgressIndicator and imageBuilder
60bb8a7 
- change default color to white in songProgressIndicator
- change default bar background color to scaffoldBackgroundColor
- removed unused spotifyImageBuilder implementation
ignaciosica pushed a commit that referenced this issue Jan 5, 2023
[#7] vote to skip
ef47cbc 
- add new widget ExpandedSection
- refactor skipButton to new file
- basic ui functionality done
ignaciosica pushed a commit that referenced this issue Jan 7, 2023
[#7] skip button working
f025b62 
- change app title
- change timer to periodic in nowPlayingDummy
- fixed firestoreRepository methods, addSkipVote, removeSkipVote and getRoom
- add room freezed model
ignaciosica pushed a commit that referenced this issue Jan 7, 2023
[#7] search functionality
1fb0bce 
- add method searchTracks in spotifyApiClient
- add methods getTrack, getQueueSnapshots and addTrackToQueue in firestoreRepository
- add method searchTracks ins spotifyRepository
- add SearchCubit and SearchState
- add SearchPage and SearchView
- add SearchAppBar with textfield
- add collection to pubspec.yaml
ignaciosica added a commit that referenced this issue Jan 7, 2023
@ignaciosica
Merge pull request #13 from p4ssenger-developer/feature/search
4fede99 
[#7] search functionality
@ignaciosica ignaciosica added this to the mvp launch milestone Jan 23, 2023
@ignaciosica ignaciosica linked a pull request Jan 23, 2023 that will close this issue
Refactor/refactor #18
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ignaciosica ignaciosica

Labels
None yet
Projects
None yet
Milestone
mvp launch
Development

Successfully merging a pull request may close this issue.

Refactor now playing ignaciosica/queue
Refactor/refactor ignaciosica/queue
1 participant
@ignaciosica