add .each method to calendar #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igneus
requested changes
Nov 8, 2017
spec/calendar_spec.rb
Outdated
| @@ -33,6 +33,14 @@ | |||
| end | |||
| end | |||
|
|
|||
| describe '.each' do | |||
| it 'yields calendar day instances' do | |||
There was a problem hiding this comment.
Please add another test checking that each actually yields. This one only checks what it yields if it yields.
lib/calendarium-romanum/calendar.rb
Outdated
| @@ -126,6 +126,12 @@ def day(*args, vespers: false) | |||
| ) | |||
| end | |||
|
|
|||
| def each | |||
| (temporale.start_date..temporale.end_date) | |||
| .map { |date| day(date) } | |||
There was a problem hiding this comment.
Both time and memory are being wasted here:
mapiterates over the date range, retrieves calendar data and collects them in a new arrayeachiterates over this array and yields it's elements
Both (retrieve calendar data, yield them) should be done in a single each. This way you save one iteration as well as memory necessary for the temporary array.
|
Hi @igneus - I really appreciate your feedback. Thanks for your patience. This is my first time using some of rspec's yield-matchers! Please review and let me know if you have any further feedback. |
|
Thanks, now everything is OK. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #14
@igneus - please let me know if you'd like any modifications to anything! it seems simple, but took me some time to orient myself to the repo.