feat(tools): auto migrate dependency tools #3505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jerónimo Albi <jeronimo.albi@tendermint.com>
Co-authored-by: Jerónimo Albi <jeronimo.albi@tendermint.com>
Co-authored-by: Jerónimo Albi <jeronimo.albi@tendermint.com>
Co-authored-by: Jerónimo Albi <jeronimo.albi@tendermint.com>
jeronimoalbi
previously approved these changes
May 17, 2023
Co-authored-by: Jerónimo Albi <jeronimo.albi@tendermint.com>
jeronimoalbi
approved these changes
May 19, 2023
|
Great PR! |
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
* create method to update go imports into a go file * add tools helpers * add migration pre handler * fix the method to update tools import * uncomment migrations questions * add changelog * idente ignite/pkg/cosmosgen/install_test.go tests Co-authored-by: Jerónimo Albi <jeronimo.albi@tendermint.com> * fix ignite/cmd/chain.go mesages Co-authored-by: Jerónimo Albi <jeronimo.albi@tendermint.com> * fix ignite/cmd/chain.go remove msg Co-authored-by: Jerónimo Albi <jeronimo.albi@tendermint.com> * ident ignite/pkg/cosmosgen/install_test.go Co-authored-by: Jerónimo Albi <jeronimo.albi@tendermint.com> * fix double ? in the ask question and improve comments * use io.writer intead return a byte array to goanalysis.UpdateInitImports method * fix goanalysis test package name * Update ignite/cmd/chain.go vars Co-authored-by: Jerónimo Albi <jeronimo.albi@tendermint.com> * run gofmt --------- Co-authored-by: Jerónimo Albi <jeronimo.albi@tendermint.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3503
Description
The tools package changes in the new SDK update and need new imports. This PR creates a feature to check what is missing and what is not used and asks if the user wants to migrate these imports.
How to test
Scaffold a chain with an old version and build with this PR version. Or you make the chain with the current version and change the tools imports manually.