Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

View transactions sent to my own address #75

Closed
0xb4rt opened this issue Apr 4, 2021 · 2 comments
Closed

View transactions sent to my own address #75

0xb4rt opened this issue Apr 4, 2021 · 2 comments
Assignees
@marinhoarthur @clockworkgr
Labels
closed-after-next-major Already solved by SF 1 but not published yet. enhancement Improvement over existing feature good first issue Good for newcomers high-priority

Comments

@0xb4rt
Copy link

0xb4rt commented Apr 4, 2021

Expected Behavior

Maybe display a new "status" for these cases or just one of them (Sent or Received).

Actual Behavior

Captura de Tela 2021-04-04 às 16 12 55
@fadeev
Copy link
Contributor

fadeev commented Apr 5, 2021

@0xb4rt good catch! Yes, if a user sends to themselves, we may need to show transaction rows: both "Sent to" and "Received from".

@marinhoarthur marinhoarthur added feature-request A new feature implementation is wished high-priority enhancement Improvement over existing feature and removed feature-request A new feature implementation is wished labels Nov 23, 2021
@marinhoarthur marinhoarthur self-assigned this Nov 29, 2021
@marinhoarthur marinhoarthur added the good first issue Good for newcomers label Dec 8, 2021
@marinhoarthur
Copy link
Contributor

marinhoarthur commented Jan 14, 2022 •
edited
Loading

update:

  • can be solved by adjusting this if and others alike but IMO let's use next major for that (i.e. solve using next implementation)

cc @Matthews3301 let's be aware of this behavior while refactoring the tx list

@marinhoarthur marinhoarthur added the closed-after-next-major Already solved by SF 1 but not published yet. label Feb 2, 2022
@mihailmarcu mihailmarcu mentioned this issue Feb 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marinhoarthur marinhoarthur

@clockworkgr clockworkgr

Labels
closed-after-next-major Already solved by SF 1 but not published yet. enhancement Improvement over existing feature good first issue Good for newcomers high-priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

View transactions sent to my own address as a single transaction ignite/web
4 participants
@fadeev @marinhoarthur @clockworkgr @0xb4rt