View transactions sent to my own address as a single transaction #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihailmarcu
requested review from
marinhoarthur and
Matthews3301
as code owners
marinhoarthur
suggested changes
Feb 16, 2022
| const x = acc.find(item => { | ||
| return item.sender === current.sender && item.receiver === current.receiver && item.timestamp === current.timestamp | ||
| }) | ||
| if (!x) { |
There was a problem hiding this comment.
this should be moved to the normalizer function inside useTxs so to keep list length -- and by doing so newTxs as well -- concise
another point: let's use hash & dir as operands
fadeev
changed the title
fadeev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & Context
If a transaction occurs in the same direction, we do the filtering and display only one. Until then, we display one transaction for each "Send" and "Receive" direction.
How To Test
Linked issue
Closes #75