Allow for custom lib and conf file placement. #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deleolajide
pushed a commit
that referenced
this pull request
Aug 18, 2014
Allow for custom lib and conf file placement. Jira OF-838
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leveraging the great custom file placement feature already built in and continuing to rely on ant for placement, these changes allows a developer to place 3rd party or private jar files that is used in code being overridden alongside the rest of the jar files in lib. Similarly, related changes in conf will also be placed appropriately during the build. An example scenario might be having a custom auth provider, which can't be placed inside a plugin, and requires 3rd party jars.
Discussion: https://community.igniterealtime.org/message/241603#241603
Note: had to re-create the pull request after switching away from master to do pulls. Previous pull request (now closed) with comments from deleolajide here: #60