XEP-0359: Fix filtering of messages applicable to SIDs. #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Btw: This fix comes courtesy to Mercury testing 😋 |
vanitasvitae
force-pushed
the
fixStanzaIDs
branch
from
7720ab1
to
3d0e571
Compare
|
Thanks :) Any reason why we don't add origin-id to every outgoing message per default? |
|
@Flowdalic we actually already did (there was a static block which added a I created #345 which makes this behaviour configurable, but also preserve it by default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed, that despite calling
sidManager.enable(), theStableAndUniqueStanzaIdManagerdid not append any<origin-id/>elements to outgoing messages.This patch fixes the filter logic, which was borked to begin with. The filter basically checked
A and not Awhich never becomes true. I wonder how this happened 🤔