Push Notifications (XEP-0357) implementation

[ramabit]

Push Notifications XEP-0357
Documentation: http://xmpp.org/extensions/xep-0357.html

• Enable push notifications
• Disable push notifications
• Parse remote disabling of push notifications

[Flowdalic]

Should use new XmlStringbuilder(this) when possible. As it makes sure that the XML is well qualified with a namespace. This is not the case in the current code since only halfOpenElement() is used which does not add xmlns. As extra plus also reduces the LOC count by one since halfOpenElement() is not required.

[ramabit]

@Flowdalic fixed

[Flowdalic]

Needs conflict resolution

[Flowdalic]

For IQ request/response sequences simply use

connection.createPacketCollectorAndSend(iq).nextResultOrThrow();

this combination takes care of canceling the collector in any case. Reduces the LOC by ~10 here.

[ramabit]

@Flowdalic before or after connection.sendStanza(iq); ?

[Flowdalic]

createPacketCollectorAndSend(IQ) does also send the stanza (look at the method name ;))

Thus the Smack Idiom to send a request IQ and get its response is

IQ request = ...;
IQ response = connection.createPacketCollectorAndSend(request).nextResultOrThrow();

[ramabit]

@Flowdalic awesome

[ramabit]

Done

[ramabit]

@Flowdalic Conflicts resolution done

[Flowdalic]

Reviewed, this appears to be ready to go after it has been squashed. Assigned SMACK-738 for it. Please mention the key somewhere in the commit message.

[ramabit]

@Flowdalic Done
Note: The continuous integration is not working ok, is throwing errors for all branches in files that I didn't modify

[Flowdalic]

Thanks, cherry picked ase266b1acd804c428cde26fa99fac265d9811612e

Note that putting the issue key in the commit title is discouraged.