SPARK-1757 & SPARK-1649: Don't process MUC history as regular messages. #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when joining a multi user chat room, the recent history of that room can be sent to the client. A bug in Spark caused these mesages to be processed as history (which is good), but also as regular/new messages (which is wrong). As a result of this, the messages could be presented in the wrong order on screen (SPARK-1757), as the original date of the message was not processed. Also, all event listeners got triggered, causing other components to act as if a new message was received. This causes issues like SPARK-1649 (unwanted notifications). Finally, the history was being saved in the local history - which can introduce some duplication there (when a room is rejoined frequently).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when joining a multi user chat room, the recent history of that room can be sent to the client.
A bug in Spark caused these mesages to be processed as history (which is good), but also as
regular/new messages (which is wrong). As a result of this, the messages could be presented in
the wrong order on screen (SPARK-1757), as the original date of the message was not processed.
Also, all event listeners got triggered, causing other components to act as if a new message
was received. This causes issues like SPARK-1649 (unwanted notifications). Finally, the history
was being saved in the local history - which can introduce some duplication there (when a room
is rejoined frequently).