Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitoring plugin does not retrieve last page of chat history when <before> is empty #76

Closed
deleolajide opened this issue Jan 15, 2020 · 1 comment

Comments

@deleolajide
Copy link
Member

Converse sends an emtpy on the first MAM request. Monitoring plugin assumes empty is missing . With no or paging set, it sets the database offset to zero and fetches the first records it can find.

XEP-0059 does not say anything about what should happen when is empty. It should interpret this as "give me all last messages"

deleolajide added a commit that referenced this issue Jan 15, 2020
Monitoring plugin does not retrieve last page of chat history when <before> is empty
@guusdk
Copy link
Member

guusdk commented Jan 23, 2020

This behavior is specified in this section of the RSM XEP: https://xmpp.org/extensions/xep-0059.html#last

@guusdk guusdk closed this as completed in 6dd60ab Jan 23, 2020
akrherz pushed a commit to akrherz/openfire-monitoring-plugin that referenced this issue Oct 30, 2020
Monitoring plugin does not retrieve last page of chat history when <before> is empty
akrherz pushed a commit to akrherz/openfire-monitoring-plugin that referenced this issue Oct 30, 2020
Monitoring plugin does not retrieve last page of chat history when <before> is empty
akrherz pushed a commit to akrherz/openfire-monitoring-plugin that referenced this issue Dec 1, 2020
Monitoring plugin does not retrieve last page of chat history when <before> is empty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants