Fixes for 'conversations' page (when auto-updating) #207
Conversation
There was a problem hiding this comment.
This appears to work for the second case in the issue. When there are no conversations (e.g. a new instance) and the call to the API returns the same empty body, the messaging about No active conversations remains.
For the first instance, where a conversation exists, the page returns an HTTP/500 on junior cluster nodes.
2021.12.20 12:53:40 ERROR [Jetty-QTP-AdminConsole-34]: org.jivesoftware.openfire.plugin.util.cache.ClusteredCacheFactory - Failed to execute cluster task
com.hazelcast.nio.serialization.HazelcastSerializationException: Problem while reading Externalizable class: org.jivesoftware.openfire.archive.Conversation, exception: java.io.IOException: java.lang.ClassNotFoundException: org.jivesoftware.openfire.archive.UserParticipations
at com.hazelcast.internal.serialization.impl.JavaDefaultSerializers$ExternalizableSerializer.read(JavaDefaultSerializers.java:159) ~[?:?]
<lots of Hazelcast internals here>
at org.jivesoftware.util.cache.CacheFactory.doSynchronousClusterTask(CacheFactory.java:777) ~[xmppserver-4.7.0-SNAPSHOT.jar:4.7.0-SNAPSHOT]
at org.jivesoftware.openfire.archive.ConversationManager.getConversations(ConversationManager.java:552) ~[?:?]
at org.jivesoftware.openfire.plugin.monitoring.conversations_jsp._jspService(conversations_jsp.java:171) ~[?:?]
at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:71) ~[apache-jsp-8.5.54.jar:8.5.54]
This was tested in a clustered setup using Openfire @ master (99e8b22)
|
Gonna attempt a rebase, maybe that will fix this... |
|
I think rebasing might help, as what you're reporting sounds an awful lot like the issue that Emiel recently fixed with #209 |
Fishbowler
force-pushed
the
206_active-conversations-admin-page-autoupdate
branch
from
c7c5b75
to
f15a3bd
Compare
The admin page that shows active conversations should properly display group chats after an automatic update of its content. When no conversations are active any more, then the table should contain a message to that effect. fixes igniterealtime#206
Fishbowler
force-pushed
the
206_active-conversations-admin-page-autoupdate
branch
from
f15a3bd
to
29e3bba
Compare
|
Yep, that resolved the error. Testing... |
|
When the last conversation times out, the API call returns an empty object, and the screen returns to "No active conversations" 👍 |
The admin page that shows active conversations should properly display group chats after an automatic update of its content.
When no conversations are active any more, then the table should contain a message to that effect.
fixes #206