Properly display conversations on junior node after plugin reload #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… monitoring plugin objects that are exchanged with other cluster nodes in task execution
Creating the JAXB context might be somewhat resource intensive. As we're lazily initializing things, we'd better guard against multiple threads trying to do the same.
Pet peeve. I've battled to many bugs that would've been very easy to fix when some kind of unexpected exception wasn't ignored.
Much of the code that depends on this declares IOExceptions to happen when serialization fails. We might as well make use of that.
|
Emiel, I've added my review as a boatload of small (and thus easily reviewable) add-on commits. Would you mind checking if anything doesn't sit well with you? |
Everything sits well with me! |
This was referenced Dec 20, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #120 and #170.
Cluster tasks of this plugin now contain String representations of conversations, instead of of the Conversation objects themselves. This prevents the class loading errors observed in #120 and #170. Furthermore, this prevents similar problems that occured after the plugin was reloaded on one of the nodes.