Fixes #210 and #208 #211
Fixes #210 and #208 #211
Conversation
|
Appears to "work" but seeing lots of instances of API misses on the plugin's pages. e.g. GET http://xmpp1.localhost.example:9091/plugins/monitoring/api/buildprogress 404 (Not Found) This doesn't occur on master, so I considered that it might be an effect of Jersey API wiring? Tested using Openfire @ master (99e8b22) |
|
This will only work with Openfire master after igniterealtime/Openfire#1945 has been merged (which currently isn't the case). Can you retry with this Openfire branch: guusdk:OF-2352_use-plugin-provided-servlet-context (or: review/merge that PR)? |
|
Aw man, I didn't even check to see if it was merged 🤦 |
Fishbowler
force-pushed
the
update-jersey
branch
from
ab17b1c
to
a97596a
Compare
|
Using a rebased version of this against a rebased version of OF-2352, the errors all disappear. Everything appears operation, except that I can't get Openfire to reliably recognise an active conversation. The users count goes up, but conversations regularly remains at 0. Suspect this might be related to which cluster node is senior. |
Note that this change depends on OF-2352. This is _not_ in Openfire 4.7.0 beta (but should be merged before Openfire 4.7.0 is released).
Fishbowler
force-pushed
the
update-jersey
branch
from
a97596a
to
d0700be
Compare
|
This issue is caused by the new to-and-from XML serialization that was put in by #209 (to fix #120 and #170). The |
…onversationEvent If ConversationEvent can't be marshalled to/from XML, then events won't ever be pushed successfully from junior cluster nodes to the senior node.
|
I've pushed a provisional change (I might want to clean this up a little), that should fix the problem. It seems to work for me. |
…n-specific The XmlSerializer was intended to be generic, but is used in only one invocation. To make it easier to test the implementation, this commit turns the generic implementation into something that is specific to this plugin.
The DAO-like functionality that existed in the Conversation class made it hard to operate on instances. This commit splits off that functionality in a new, dedicated class named ConversationDAO. No functional changes are expected from this.
Improved the XML-based serialization that got introduced as a fix for igniterealtime#120/igniterealtime#170 Dropped Externalization (supposed to be replaced with XML-based serialization) to reduce complexity. Added unit tests to verify XML-based serialization functionality.
|
I've now pushed a more substantial fix, that also includes some unit tests that help verify the XML serialization bit. Should be good to go now. |
|
My observed problem no longer occurs, and still fixes both intended issues 👍 |
Note that the fix for #210 requires OF-2352 / igniterealtime/Openfire#1945 which means that this PR will not work with 4.7.0 beta (but hopefully will with 4.7.0 non-beta).