Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #76 #77

Merged
merged 2 commits into from Jan 23, 2020
Merged

fix #76 #77

merged 2 commits into from Jan 23, 2020

Conversation

deleolajide
Copy link
Member

Monitoring plugin does not retrieve last page of chat history when is empty
This fix adds handling of xmppResultSet.isPagingBackwards() in findMessages()

Monitoring plugin does not retrieve last page of chat history when <before> is empty
@guusdk
Copy link
Member

guusdk commented Jan 23, 2020

Travis insists that this does not compile. Does it?

Your fix seems to be limited to the non-MUC archives. Does this problem need to be fixed in the MUC archives too?

Would you be so kind at to add the issue that's fixed to the changelog? :)

@deleolajide
Copy link
Member Author

Does this problem need to be fixed in the MUC archives too?

As far as I can tell, this issue is not being exhibited in the findMessages method of MucMamPersistenceManager. I have not looked into detail as to why. If it does later, I know where to find it :-)

Travis insists that this does not compile. Does it?

I have this fix running on wikisuite.chat and using it everyday. I have no clue what is up with Travis, but I will check on any missing dependencies.

Would you be so kind at to add the issue that's fixed to the changelog? :)

Sure thing

@deleolajide
Copy link
Member Author

deleolajide commented Jan 23, 2020

Travis insists that this does not compile. Does it?

Apparently it does not. Sorry about that. I have no clue on how the code got regressed.

@guusdk guusdk merged commit 10c42bd into master Jan 23, 2020
@deleolajide deleolajide deleted the fixing-issue-76 branch January 23, 2020 22:48
guusdk added a commit to guusdk/openfire-monitoring-plugin that referenced this pull request Jan 24, 2020
The last few commits were based on a branch, that got rebased upon the changes that were in igniterealtime#77

Somewhere along the line in my branch, variable names changed. This commit sets the record straight.
guusdk added a commit that referenced this pull request Jan 28, 2020
The last few commits were based on a branch, that got rebased upon the changes that were in #77

Somewhere along the line in my branch, variable names changed. This commit sets the record straight.
akrherz pushed a commit to akrherz/openfire-monitoring-plugin that referenced this pull request Oct 30, 2020
The last few commits were based on a branch, that got rebased upon the changes that were in igniterealtime#77

Somewhere along the line in my branch, variable names changed. This commit sets the record straight.
akrherz pushed a commit to akrherz/openfire-monitoring-plugin that referenced this pull request Oct 30, 2020
The last few commits were based on a branch, that got rebased upon the changes that were in igniterealtime#77

Somewhere along the line in my branch, variable names changed. This commit sets the record straight.
akrherz pushed a commit to akrherz/openfire-monitoring-plugin that referenced this pull request Dec 1, 2020
The last few commits were based on a branch, that got rebased upon the changes that were in igniterealtime#77

Somewhere along the line in my branch, variable names changed. This commit sets the record straight.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants