Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issues #48 and #72, improve performance #96

Closed
wants to merge 5,858 commits into from
Closed

fix issues #48 and #72, improve performance #96

wants to merge 5,858 commits into from

Conversation

koledas
Copy link

@koledas koledas commented Mar 26, 2020

guusdk and others added 30 commits February 16, 2013 19:32
@guusdk
OF-619: Replaced json.jar with a java 5 compatible variant.
dc3f1a2 
git-svn-id: http://svn.igniterealtime.org/svn/repos/openfire/trunk@13495 b35dd754-fafc-0310-a699-88a17e54d16e
@guusdk
OF-619: Removed @OverRide annotations that are invalid in Java 5.
fa2bb96 
git-svn-id: http://svn.igniterealtime.org/svn/repos/openfire/trunk@13496 b35dd754-fafc-0310-a699-88a17e54d16e
@guusdk
OF-620: Should be java 5 compatible.
3832aa1 
OF-621: Fix potential NPE.


git-svn-id: http://svn.igniterealtime.org/svn/repos/openfire/trunk@13497 b35dd754-fafc-0310-a699-88a17e54d16e
@guusdk
OF-620: Should be java 5 compatible.
84c0e31 
OF-621: Fix potential NPE.


git-svn-id: http://svn.igniterealtime.org/svn/repos/openfire/trunk@13498 b35dd754-fafc-0310-a699-88a17e54d16e
Don't forward Subscription:Remove IQ of transport itself to the serve…
49caea6 
…r as it will throw a exception

git-svn-id: http://svn.igniterealtime.org/svn/repos/openfire/trunk@13499 b35dd754-fafc-0310-a699-88a17e54d16e
@guusdk
OF-102: Delete enries from ofUserProp when user is deleted (patch by …
025b6df 
…Peter Johnson).

git-svn-id: http://svn.igniterealtime.org/svn/repos/openfire/trunk@13500 b35dd754-fafc-0310-a699-88a17e54d16e
@guusdk
OF-102: Group caching should not make changes invisible to the end us…
86e9716 
…er (patch by Peter Johnson).

git-svn-id: http://svn.igniterealtime.org/svn/repos/openfire/trunk@13501 b35dd754-fafc-0310-a699-88a17e54d16e
more debug information output
2d04c17 
git-svn-id: http://svn.igniterealtime.org/svn/repos/openfire/trunk@13502 b35dd754-fafc-0310-a699-88a17e54d16e
small fixes in gojara version and changelog
771cac8 
git-svn-id: http://svn.igniterealtime.org/svn/repos/openfire/trunk@13503 b35dd754-fafc-0310-a699-88a17e54d16e
GoJara 1.2.4 fixed access control bug
66f7a05 
git-svn-id: http://svn.igniterealtime.org/svn/repos/openfire/trunk@13504 b35dd754-fafc-0310-a699-88a17e54d16e
test for serverDomain earlier
4b34d8b 
git-svn-id: http://svn.igniterealtime.org/svn/repos/openfire/trunk@13505 b35dd754-fafc-0310-a699-88a17e54d16e
GoJara minor fixes v1.2.5
fcd1adf 
git-svn-id: http://svn.igniterealtime.org/svn/repos/openfire/trunk@13506 b35dd754-fafc-0310-a699-88a17e54d16e
@guusdk
Updating the Tinder dependency to a recent SNAPSHOT release, as this …
c9ff3e8 
…includes better debug logging for JIDs (TINDER-67) as well as a new utility method that helps to build valid bare JID instances (TINDER-68). The latter should help prevent issues like OF-624.

git-svn-id: http://svn.igniterealtime.org/svn/repos/openfire/trunk@13510 b35dd754-fafc-0310-a699-88a17e54d16e
@guusdk
Updating the Tinder dependency to a recent SNAPSHOT release, as this …
58cce9e 
…includes better debug logging for JIDs (TINDER-67) as well as a new utility method that helps to build valid bare JID instances (TINDER-68). The latter should help prevent issues like OF-624.

git-svn-id: http://svn.igniterealtime.org/svn/repos/openfire/trunk@13511 b35dd754-fafc-0310-a699-88a17e54d16e
@guusdk
Undoing local change that was checked in by accident.
ab6789e 
git-svn-id: http://svn.igniterealtime.org/svn/repos/openfire/trunk@13512 b35dd754-fafc-0310-a699-88a17e54d16e
@guusdk
OF-624: Added some defensive coding fragments (utilizing TINDER-68) t…
3795fd1 
…hat helps to prevent generating illegal JIDs.

git-svn-id: http://svn.igniterealtime.org/svn/repos/openfire/trunk@13513 b35dd754-fafc-0310-a699-88a17e54d16e
@guusdk
Fixing config template.
c3a8af6 
git-svn-id: http://svn.igniterealtime.org/svn/repos/openfire/trunk@13514 b35dd754-fafc-0310-a699-88a17e54d16e
@akrherz
update to JRE 1.6u41, refs OF-627
124ab15 
git-svn-id: http://svn.igniterealtime.org/svn/repos/openfire/trunk@13515 b35dd754-fafc-0310-a699-88a17e54d16e
OF-623 Create node hierarchy after all nodes are created
05aafba 
git-svn-id: http://svn.igniterealtime.org/svn/repos/openfire/trunk@13516 b35dd754-fafc-0310-a699-88a17e54d16e
@tevans
OF-596: Lazy-load lastPublished item when needed
15d936c 
git-svn-id: http://svn.igniterealtime.org/svn/repos/openfire/trunk@13518 b35dd754-fafc-0310-a699-88a17e54d16e
@tevans
OF-597: Improve query performance for lastPublishedItem
fecfec0 
git-svn-id: http://svn.igniterealtime.org/svn/repos/openfire/trunk@13519 b35dd754-fafc-0310-a699-88a17e54d16e
@Flowdalic
IQRouter: Log xml in case of processing iq answer error
70fa23c 
git-svn-id: http://svn.igniterealtime.org/svn/repos/openfire/trunk@13523 b35dd754-fafc-0310-a699-88a17e54d16e
@Flowdalic
Makefile: Added dbkg target
e0c8dac 
git-svn-id: http://svn.igniterealtime.org/svn/repos/openfire/trunk@13524 b35dd754-fafc-0310-a699-88a17e54d16e
@Flowdalic
EntityCapabilitiesManager: Don't handle IQ stanzas with came in throu…
b815c26 
…gh receivedAnswer() but are not of IQ.Type.result by deeming these packets as invalid (which they are).

It seems that there are some entities that accounce protocol/caps support but do not allow disco#info queries (maybe to avoid information leaks). They send an error IQ instead as rely to disco#info. This causes EntityCapabilitiesManager to throw an NPE:

2013.02.26 13:16:33 org.jivesoftware.openfire.IQRouter - Error proces
sing answer of remote entity. Answer: <iq from="jdev@conference.jabbe
r.org/XXX" to="freakempire.de" type="error" id="204-29"><error c
ode="405" type="cancel"><not-allowed xmlns="urn:ietf:params:xml:ns:xm
pp-stanzas"/></error></iq>
java.lang.NullPointerException
        at org.jivesoftware.openfire.entitycaps.EntityCapabilitiesMan
ager.getIdentitiesFrom(EntityCapabilitiesManager.java:336)
        at org.jivesoftware.openfire.entitycaps.EntityCapabilitiesMan
ager.generateVerHash(EntityCapabilitiesManager.java:237)

git-svn-id: http://svn.igniterealtime.org/svn/repos/openfire/trunk@13525 b35dd754-fafc-0310-a699-88a17e54d16e
@Flowdalic
OF-636 Use default-jvm if available
eb984da 
git-svn-id: http://svn.igniterealtime.org/svn/repos/openfire/trunk@13526 b35dd754-fafc-0310-a699-88a17e54d16e
@guusdk
Preparing for 3.8.1 release.
b74c2b9 
git-svn-id: http://svn.igniterealtime.org/svn/repos/openfire/trunk@13535 b35dd754-fafc-0310-a699-88a17e54d16e
@Flowdalic
OF-476 - Made input processing of FlashCrossDomainHandler more robust…
ddcff97 
…: Abort when EOF is encounterd or when more then 100 invalid CodePoints are read.

git-svn-id: http://svn.igniterealtime.org/svn/repos/openfire/trunk@13537 b35dd754-fafc-0310-a699-88a17e54d16e
@Flowdalic
OF-646 The matches where accidentially interchanged. Added small test…
9718a46 
…case

git-svn-id: http://svn.igniterealtime.org/svn/repos/openfire/trunk@13541 b35dd754-fafc-0310-a699-88a17e54d16e
@Flowdalic
OF-646 Made it clear that DateTime.parse() also may return null. Fixe…
82897d9 
…d muc/HistoryRequest.java

git-svn-id: http://svn.igniterealtime.org/svn/repos/openfire/trunk@13542 b35dd754-fafc-0310-a699-88a17e54d16e
@Flowdalic
Added eclipse settings
4d6318d 
git-svn-id: http://svn.igniterealtime.org/svn/repos/openfire/trunk@13543 b35dd754-fafc-0310-a699-88a17e54d16e
guusdk and others added 20 commits January 28, 2020 15:30
@guusdk
for igniterealtime#62: Add changelog entry.
8d31fd8
@guusdk
fixes igniterealtime#80: Embedded database only: Prevent all messages…
cd05793 
… to be returned when only a count is requested.

Not querying the database for messages if you're requesting zero messages to be returned makes sense from a performance perspective. Additionally, the existing code trips what appears to be a bug in HSQLDB which appears to return all rows (instead of no rows) if you end a query with "LIMIT 0".
@guusdk
for igniterealtime#63: Use standardized field name for MAM text searc…
c032914 
…h queries.

Change the name of the field used for text searches to what's defined in https://xmpp.org/extensions/inbox/fulltext.html
@guusdk
fixes igniterealtime#81: Allow for non-standard MUC MAM text search f…
50b7b20 
…ields to be used.

The MAM search should allow non-standard fields known to be used by other implementations, when the standard equivalent is not used.
@guusdk
for igniterealtime#63: fix typo in field name.
edec0a5
@guusdk
for igniterealtime#82: Split off pagination from retrieval.
11bb542 
This commit should not introduce a functional change. It applies the same split that's applied to the Lucene-based retrieval, that splits off the arguments that define the resultset from the arguments that define the page from the resultset to return.
@guusdk
fixes igniterealtime#82: Fix RSM count.
dd066d2 
This fixes a problem where, when retrieved from the database (instead of Lucene) the 'total' count of items in the result set was reported with an incorrect value.
@guusdk
Rebase correction
f975b52 
The last few commits were based on a branch, that got rebased upon the changes that were in igniterealtime#77

Somewhere along the line in my branch, variable names changed. This commit sets the record straight.
@guusdk
fixes igniterealtime#70: Purge null RRDs from database when starting.
075b2d9 
Apparently, something occasionally corrupts the database table that stores the RRDS holding statistics. When one row is corrupt, it affects the functionality of all statistics.

To work around this issue, this commit removes all affected rows upon start of the plugin. This will cause the code to recreate the row with a valid structure, and re-enables usage of all other statistics.
@guusdk
Fix HTML in Changelog
b83d2e6
@guusdk
for igniterealtime#63: Ensure correct order of messages
5f10439 
When querying the Lucene index, ensure that the order of messages is old-to-new, even when paging backwards through a result set.
@guusdk
fixes igniterealtime#84: Return error on unrecognized MAM query fields.
c83bae7 
Some clients use a data form field that is unrecognized. Up until now, the monitoring plugin has ignored those fields. This can lead to unexpected results, as the client (and end user) assume that a certain limitation is applied to the search, while in fact, it is not.

The plugin should return an error when unsupported fields are used, instead of silently ignoring them.

This behavior can be configured by using the 'monitoring.search.allow-unrecognized-fields' property.
@guusdk
Make (some) settings configurable.
141fe24 
Added properties:
- `archive.settings.logapi.enabled` to allow configuration of exposure of the API that is used to display logs from public chatrooms (defaults to 'false')
- `monitoring.search.allow-unrecognized-fields` to return an error or silently ignore MAM queries with unrecognized fields (defaults to 'false', triggering an error)
@guusdk
fixes igniterealtime#35: Add webpage to access MUC logs
5d10320 
This commit adds a webpage that uses the API that was added earlier to allow uses to view groupchat logs in their browser.
@guusdk
for igniterealtime#35: Make timestamps in UI UTC.
10c2064
@guusdk
Denote version 2.0.0
123ddaa
@guusdk
Increment version number to next SNAPSHOT.
c84529f
@akrherz
Merge pull request igniterealtime#86 from guusdk/release_2.0.0
4f6229f 
Release 2.0.0
@koledas
fix issues igniterealtime#48 and igniterealtime#72, improve performance
386b48b 
Fix Issues igniterealtime#48 and igniterealtime#72.
Improve performance load conversations.
Tested on PostgreSQL 11.7, size of DB 7Gb. Client Vacuum-IM 1.3.0.
@koledas
Merge pull request #1 from koledas/fix-issues-#48-and-igniterealtime#72
f9d4ccb 
fix issues igniterealtime#48 and igniterealtime#72, improve performance
@koledas koledas mentioned this pull request Jun 15, 2020
Closed
@DavisR-GitHub
Copy link

DavisR-GitHub commented Jun 18, 2020 •
edited

Why nobody merges this request?

@guusdk
Copy link
Member

guusdk commented Jun 19, 2020

The change in this PR is rather large, and addresses more than one issue. This makes reviewing more complex. It is generally preferable to create distinct, concise PRs, as that will help reviewers process things faster.

It's understandable that PRs that take a long time to be reviewed can be frustrating. Please do remember that the community consists of volunteers, that sometimes have other priorities.

@DavisR-GitHub
Copy link

@koledas,
May be you could split this request into several small requests?
We really need in these fixes.

@koledas
Copy link
Author

koledas commented Jun 22, 2020

@DavisR-GitHub
Sorry, but why is there such a rush?
You can use this plugin: https://github.com/igniterealtime/openfire-monitoring-plugin/files/4387326/monitoring.zip
And my fork: https://github.com/koledas/openfire-monitoring-plugin
Now it’s hard to remember which change related to which problem. In the future I will create distinct, concise PRs.

@DavisR-GitHub
Copy link

Rush?
Pull request was created 3 month ago and still even did not reviewed...

@guusdk
Copy link
Member

guusdk commented Sep 10, 2020

#72 is now fixed in #123

@akrherz
Copy link
Member

akrherz commented Oct 30, 2020

Sorry, this PR will need to be resubmitted, I was not able to fix it after the repository rewrite to remove unrelated commits.

@akrherz akrherz closed this Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet