Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make triangle icon usable #58

Closed
rodrigolzd opened this issue Sep 23, 2018 · 6 comments
Closed

Make triangle icon usable #58

rodrigolzd opened this issue Sep 23, 2018 · 6 comments

Comments

@rodrigolzd
Copy link

The grouping triangle icon should be clickable and just as functional as the text, it seems more natural to use the icon as a control to expand and collapse the lists.

@deleolajide
Copy link
Member

Agreed. A PR to fix this is most welcome

@luciash
Copy link
Contributor

luciash commented Nov 5, 2018

This can be closed, right?

@deleolajide
Copy link
Member

Yes, thanks

@luciash
Copy link
Contributor

luciash commented Nov 6, 2018

Ah, sorry, the triangle icon is still not toggleable on click... oops :) I thought the issue was actually the opposite (text not clickable to toggle).

Edit: Doh, the caret is sometimes clickable and sometimes it is not (very intermittent) - weird! It is like of you click in the middle of the caret exactly it does not work... but slightly left or right of it the toggle gets triggered.

@rodrigolzd
Copy link
Author

so, this is going to be open again?

@luciash
Copy link
Contributor

luciash commented Nov 29, 2018

@deleolajide When I click the triangle I get in the Chrome DevTools console:

Uncaught TypeError: Cannot read property 'classList' of null
    at child.toggleRoomsList (converse.js:58793)
    at wrapper (converse.js:13440)
    at HTMLDivElement.handler (converse.js:1005)
  | toggleRoomsList | @ | converse.js:58793
  | wrapper | @ | converse.js:13440
  | handler | @ | converse.js:1005

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants