Change package names from ignition_ to ign_ #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <ahcorde@gmail.com>
chapulina
reviewed
Jan 5, 2022
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
chapulina
approved these changes
Jan 6, 2022
There was a problem hiding this comment.
LGTM when cpplint is happy:
2022-01-06T19:02:35.2107467Z 3: /home/ros2_ws/src/ign_ros2_control/ign_ros2_control/include/ign_ros2_control/ign_ros2_control_plugin.hpp:15: #ifndef header guard has wrong style, please use: IGN_ROS2_CONTROL__IGN_ROS2_CONTROL_PLUGIN_HPP_ [build/header_guard] [5]
2022-01-06T19:02:35.2108841Z 3: /home/ros2_ws/src/ign_ros2_control/ign_ros2_control/include/ign_ros2_control/ign_ros2_control_plugin.hpp:62: #endif line should be "#endif // IGN_ROS2_CONTROL__IGN_ROS2_CONTROL_PLUGIN_HPP_" [build/header_guard] [5]
2022-01-06T19:02:35.2110069Z 3: /home/ros2_ws/src/ign_ros2_control/ign_ros2_control/include/ign_ros2_control/ign_system.hpp:16: #ifndef header guard has wrong style, please use: IGN_ROS2_CONTROL__IGN_SYSTEM_HPP_ [build/header_guard] [5]
2022-01-06T19:02:35.2111233Z 3: /home/ros2_ws/src/ign_ros2_control/ign_ros2_control/include/ign_ros2_control/ign_system.hpp:79: #endif line should be "#endif // IGN_ROS2_CONTROL__IGN_SYSTEM_HPP_" [build/header_guard] [5]
2022-01-06T19:02:35.2112444Z 3: /home/ros2_ws/src/ign_ros2_control/ign_ros2_control/include/ign_ros2_control/ign_system_interface.hpp:16: #ifndef header guard has wrong style, please use: IGN_ROS2_CONTROL__IGN_SYSTEM_INTERFACE_HPP_ [build/header_guard] [5]
2022-01-06T19:02:35.2113708Z 3: /home/ros2_ws/src/ign_ros2_control/ign_ros2_control/include/ign_ros2_control/ign_system_interface.hpp:108: #endif line should be "#endif // IGN_ROS2_CONTROL__IGN_SYSTEM_INTERFACE_HPP_" [build/header_guard] [5]
2022-01-06T19:02:35.2115165Z 3: Category 'build/header_guard' errors found: 6
ahcorde
added a commit
that referenced
this pull request
Jan 6, 2022
* Change package names from ignition_ to ign_ Signed-off-by: ahcorde <ahcorde@gmail.com>
ahcorde
added a commit
that referenced
this pull request
Jan 6, 2022
This was referenced Jan 6, 2022
ahcorde
added a commit
to ahcorde/rosdistro
that referenced
this pull request
Jan 7, 2022
Increasing version of package(s) in repository `ign_ros2_control` to `0.1.1-2`: - upstream repository: https://github.com/ignitionrobotics/ign_ros2_control - release repository: https://github.com/ros2-gbp/ign_ros2_control-release.git - distro file: `foxy/distribution.yaml` - bloom version: `0.10.7` - previous version for package: `null` ``` * Change package names from ignition_ to ign_ (ros#19 <ros-controls/gz_ros2_control#22>) * Change package names from ignition_ to ign_ * Contributors: Alejandro Hernández Cordero ``` ``` * Change package names from ignition_ to ign_ (ros#19 <ros-controls/gz_ros2_control#19>) * Change package names from ignition_ to ign_ * Added missing dependencies to package.xml (ros#18 <ros-controls/gz_ros2_control#21>) * Contributors: Alejandro Hernández Cordero ``` Signed-off-by: ahcorde <ahcorde@gmail.com>
clalancette
pushed a commit
to ros/rosdistro
that referenced
this pull request
Jan 7, 2022
* ign_ros2_control: 0.1.1-2 in 'foxy/distribution.yaml' [bloom] Increasing version of package(s) in repository `ign_ros2_control` to `0.1.1-2`: - upstream repository: https://github.com/ignitionrobotics/ign_ros2_control - release repository: https://github.com/ros2-gbp/ign_ros2_control-release.git - distro file: `foxy/distribution.yaml` - bloom version: `0.10.7` - previous version for package: `null` ``` * Change package names from ignition_ to ign_ (#19 <ros-controls/gz_ros2_control#22>) * Change package names from ignition_ to ign_ * Contributors: Alejandro Hernández Cordero ``` ``` * Change package names from ignition_ to ign_ (#19 <ros-controls/gz_ros2_control#19>) * Change package names from ignition_ to ign_ * Added missing dependencies to package.xml (#18 <ros-controls/gz_ros2_control#21>) * Contributors: Alejandro Hernández Cordero ``` Signed-off-by: ahcorde <ahcorde@gmail.com> * make linters happy Signed-off-by: ahcorde <ahcorde@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ahcorde ahcorde@gmail.com
🦟 Bug fix
Summary
Change package names from ignition_ to ign_
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.