-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Diff drive example #28
Conversation
Signed-off-by: ahcorde <ahcorde@gmail.com>
pose_covariance_diagonal : [0.001, 0.001, 0.001, 0.001, 0.001, 0.01] | ||
twist_covariance_diagonal: [0.001, 0.001, 0.001, 0.001, 0.001, 0.01] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is 2-D odometry, I believe the convention is to zero out the covariance for z
, roll
, pitch
, y_dot
, and z_dot
.
pose_covariance_diagonal : [0.001, 0.001, 0.001, 0.001, 0.001, 0.01] | |
twist_covariance_diagonal: [0.001, 0.001, 0.001, 0.001, 0.001, 0.01] | |
pose_covariance_diagonal : [0.001, 0.001, 0, 0, 0, 0.01] | |
twist_covariance_diagonal: [0.001, 0, 0, 0, 0, 0.01] |
arguments=['-string', doc.toxml(), | ||
'-name', 'cartpole', | ||
'-allow_renaming', 'true'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not to be addressed here, but do you know why these aren't ROS parameters versus command line arguments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest I don't know, but maybe because the compatibility between ros and ros2 it's easy and it's a ignition tool more than a ros. Just guessing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with ROS 2 Foxy and Ignition Fortress and the diff drive controller example works as expected. I just have the one comment about the covariance and this should be good to go.
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde ahcorde@gmail.com
馃帀 New feature
Summary
Added Diff drive example
Test it
In one terminal:
in other terminal:
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.