Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Diff drive example #28

Merged
merged 2 commits into from
Feb 4, 2022
Merged

Added Diff drive example #28

merged 2 commits into from
Feb 4, 2022

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Jan 18, 2022

Signed-off-by: ahcorde ahcorde@gmail.com

馃帀 New feature

Summary

Added Diff drive example

diff_drive

Test it

In one terminal:

ros2 launch ign_ros2_control_demos cart_diff_drive.launch.py

in other terminal:

ros2 run ign_ros2_control_demos example_diff_drive

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Jan 18, 2022
@osrf-triage osrf-triage added this to Inbox in Core development Jan 18, 2022
@chapulina chapulina moved this from Inbox to In review in Core development Jan 18, 2022
@mjcarroll mjcarroll self-requested a review February 1, 2022 18:24
Comment on lines 27 to 28
pose_covariance_diagonal : [0.001, 0.001, 0.001, 0.001, 0.001, 0.01]
twist_covariance_diagonal: [0.001, 0.001, 0.001, 0.001, 0.001, 0.01]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is 2-D odometry, I believe the convention is to zero out the covariance for z, roll, pitch, y_dot, and z_dot.

Suggested change
pose_covariance_diagonal : [0.001, 0.001, 0.001, 0.001, 0.001, 0.01]
twist_covariance_diagonal: [0.001, 0.001, 0.001, 0.001, 0.001, 0.01]
pose_covariance_diagonal : [0.001, 0.001, 0, 0, 0, 0.01]
twist_covariance_diagonal: [0.001, 0, 0, 0, 0, 0.01]

Comment on lines +59 to +61
arguments=['-string', doc.toxml(),
'-name', 'cartpole',
'-allow_renaming', 'true'],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not to be addressed here, but do you know why these aren't ROS parameters versus command line arguments?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest I don't know, but maybe because the compatibility between ros and ros2 it's easy and it's a ignition tool more than a ros. Just guessing

Copy link

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with ROS 2 Foxy and Ignition Fortress and the diff drive controller example works as expected. I just have the one comment about the covariance and this should be good to go.

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde merged commit 9ba2ef7 into foxy Feb 4, 2022
@ahcorde ahcorde deleted the ahcorde/foxy/diff_drive branch February 4, 2022 08:33
Core development automation moved this from In review to Done Feb 4, 2022
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants