Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install ign_ros2_control_demos/urdf directory to fix demos #61

Merged
merged 1 commit into from
Jun 2, 2022

Conversation

AndrejOrsula
Copy link
Contributor

All launch scripts under ign_ros2_control_demos require ign_ros2_control_demos/urdf directory to be installed, see example (cart_example_effort.launch.py).

The installation of ign_ros2_control_demos/urdf directory was disabled as a part of #56, which I believe was an unintentional consequence of removing urdf package dependency. Therefore, this PR reverts this change.

Note: This PR targets main but all branches are affected (foxy/galactic).

馃 Bug fix

Fixes the following error that is experienced when running launch scripts included in ign_ros2_control_demos.

[ERROR] [launch]: Caught exception in launch (see debug for traceback): Caught exception when trying to load file of format [py]: [Errno 2] No such file or directory: '/root/ws_moveit/install/ign_ros2_control_demos/share/ign_ros2_control_demos/urdf/test_cart_position.xacro.urdf'

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Andrej Orsula <orsula.andrej@gmail.com>
Core development automation moved this from Inbox to In review Jun 2, 2022
@ahcorde ahcorde merged commit f721860 into ros-controls:main Jun 2, 2022
Core development automation moved this from In review to Done Jun 2, 2022
ahcorde pushed a commit that referenced this pull request Jun 2, 2022
Signed-off-by: Andrej Orsula <orsula.andrej@gmail.com>
ahcorde pushed a commit that referenced this pull request Jun 2, 2022
Signed-off-by: Andrej Orsula <orsula.andrej@gmail.com>
ahcorde added a commit that referenced this pull request Jun 6, 2022
[backport galactic] ign_ros2_control_demos: Install urdf dir (#61)
ahcorde added a commit that referenced this pull request Jun 6, 2022
[backport Foxy] ign_ros2_control_demos: Install urdf dir (#61)
@bmagyar bmagyar removed this from Done in Core development Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants