Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[forwardport main] Added missing dependencies to package.xml (#18) #21

Merged
merged 1 commit into from
Jan 6, 2022

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Jan 6, 2022

Signed-off-by: Alejandro Hernández ahcorde@gmail.com

🎉 Forward port

Summary

Added missing dependencies to package.xml

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from chapulina January 6, 2022 19:03
@ahcorde ahcorde self-assigned this Jan 6, 2022
@osrf-triage osrf-triage added this to Inbox in Core development Jan 6, 2022
Core development automation moved this from Inbox to In review Jan 6, 2022
@ahcorde ahcorde merged commit 3439681 into main Jan 6, 2022
@ahcorde ahcorde deleted the ahcorde/forwardport/18 branch January 6, 2022 19:29
Core development automation moved this from In review to Done Jan 6, 2022
ahcorde added a commit to ahcorde/rosdistro that referenced this pull request Jan 7, 2022
Increasing version of package(s) in repository `ign_ros2_control` to `0.1.1-2`:

- upstream repository: https://github.com/ignitionrobotics/ign_ros2_control
- release repository: https://github.com/ros2-gbp/ign_ros2_control-release.git
- distro file: `foxy/distribution.yaml`
- bloom version: `0.10.7`
- previous version for package: `null`

```
* Change package names from ignition_ to ign_ (ros#19 <ros-controls/gz_ros2_control#22>)
  * Change package names from ignition_ to ign_
* Contributors: Alejandro Hernández Cordero
```

```
* Change package names from ignition_ to ign_ (ros#19 <ros-controls/gz_ros2_control#19>)
  * Change package names from ignition_ to ign_
* Added missing dependencies to package.xml (ros#18 <ros-controls/gz_ros2_control#21>)
* Contributors: Alejandro Hernández Cordero
```

Signed-off-by: ahcorde <ahcorde@gmail.com>
clalancette pushed a commit to ros/rosdistro that referenced this pull request Jan 7, 2022
* ign_ros2_control: 0.1.1-2 in 'foxy/distribution.yaml' [bloom]

Increasing version of package(s) in repository `ign_ros2_control` to `0.1.1-2`:

- upstream repository: https://github.com/ignitionrobotics/ign_ros2_control
- release repository: https://github.com/ros2-gbp/ign_ros2_control-release.git
- distro file: `foxy/distribution.yaml`
- bloom version: `0.10.7`
- previous version for package: `null`

```
* Change package names from ignition_ to ign_ (#19 <ros-controls/gz_ros2_control#22>)
  * Change package names from ignition_ to ign_
* Contributors: Alejandro Hernández Cordero
```

```
* Change package names from ignition_ to ign_ (#19 <ros-controls/gz_ros2_control#19>)
  * Change package names from ignition_ to ign_
* Added missing dependencies to package.xml (#18 <ros-controls/gz_ros2_control#21>)
* Contributors: Alejandro Hernández Cordero
```

Signed-off-by: ahcorde <ahcorde@gmail.com>

* make linters happy

Signed-off-by: ahcorde <ahcorde@gmail.com>
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants