Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create CODEOWNERS with azeey and scpeters #650

Merged
merged 2 commits into from
Aug 4, 2021
Merged

Create CODEOWNERS with azeey and scpeters #650

merged 2 commits into from
Aug 4, 2021

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Aug 2, 2021

Signed-off-by: Steve Peters scpeters@openrobotics.org

@scpeters
Create CODEOWNERS with azeey and scpeters
0525f59 
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters requested a review from azeey August 2, 2021 18:10
chapulina
chapulina suggested changes Aug 2, 2021
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Each rule needs to be in one line, see gazebosim/gz-gui#251 and gazebosim/gz-cmake#155

@scpeters
fix to single line
d733e7a 
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters
Copy link
Member Author

scpeters commented Aug 2, 2021

🎉

Each rule needs to be in one line, see ignitionrobotics/ign-gui#251 and ignitionrobotics/ign-cmake#155

d733e7a

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2021 •
edited
Loading

Codecov Report

Merging #650 (d733e7a) into sdf6 (feec202) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             sdf6     #650   +/-   ##
=======================================
  Coverage   65.70%   65.70%           
=======================================
  Files          88       88           
  Lines       10163    10163           
=======================================
  Hits         6678     6678           
  Misses       3485     3485

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update feec202...d733e7a. Read the comment docs.

@chapulina chapulina merged commit f13264e into sdf6 Aug 4, 2021
@chapulina chapulina deleted the scpeters/codeowners-6 branch August 4, 2021 00:34
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-01-10/1228/1

@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-25-fortress-edifice-citadel/1343/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azeey azeey azeey approved these changes

@chapulina chapulina chapulina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@scpeters @codecov-commenter @osrf-triage @azeey @chapulina