-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add enable_orientation SDF element to imu #651
Conversation
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
the code looks fine; we just have to be careful when adding fields to the spec, both when merging forward, and in terms of back porting to do you have a plan for forward and back-porting? |
We currently don't need this in earlier versions but I can backport it if we want to keep the spec consistent? What's the process for merging forward? Should I create separate PRs to add the field to the 1.8 ( |
this would be easier if we kept the spec and parser in separate repositories. we'd probably need to add a patch number to the spec to handle new fields (i.e. 1.6.1). Until then, let's try to keep them consistent
you can copy them over to the new specs in the merge-forward pull request |
sounds good, I merge this first and then start porting to other branches. |
Signed-off-by: Ian Chen ichen@osrfoundation.org
🦟 Bug fix
Summary
Add
enable_orientation
element to SDF spec that allows users to configure whether an IMU sensor will generate and output orientation dataChecklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge