-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds enable_metrics flag to Sensor. #665
Conversation
2b809e9
to
c9196da
Compare
I recommend looking at #429 as an example for updating the specification files in the |
Thanks, I will check. |
Hey @scpeters , some updates:
I've updated only the 1.7 specification file but I found that in other PRs the specification is updated for several versions. Should I add it to the 1.5 and 1.6 too?
I've added only unit test for the addition of the new attribute. |
297341d
to
3035e0f
Compare
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
3035e0f
to
4d9093d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @francocipollone , LGTM!
I didn't find information about which version I should target.
libSDFormat9 supports the 1.7 spec, so I think adding to that is enough.
Signed-off-by: Franco Cipollone franco.c@ekumenlabs.com
🎉 New feature
Related to gazebosim/gz-sensors#146 (comment)
Summary
<enable_metrics>
attribute was added toSensor
.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge