Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added <shininess> to <material> #985

Merged
merged 3 commits into from Apr 22, 2022
Merged

Conversation

WilliamLewww
Copy link
Contributor

@WilliamLewww WilliamLewww commented Apr 18, 2022

🎉 Added <shininess> to <material>

Summary

When using default shaders in gazebo, the ogre's default shininess is 0 causing the specular components to have no effect. Without having a shininess element, we are unable to utilize specular highlights with default shaders.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏰 citadel Ignition Citadel labels Apr 18, 2022
@osrf-triage osrf-triage added this to Inbox in Core development Apr 18, 2022
Copy link
Collaborator

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI

/github/workspace/include/sdf/Material.hh:119:  Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4]

Core development automation moved this from Inbox to In review Apr 18, 2022
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2022

Codecov Report

Merging #985 (380af1b) into sdf9 (1491d72) will decrease coverage by 44.10%.
The diff coverage is n/a.

❗ Current head 380af1b differs from pull request most recent head 5329adb. Consider uploading reports for the commit 5329adb to get more accurate results

@@             Coverage Diff             @@
##             sdf9     #985       +/-   ##
===========================================
- Coverage   87.58%   43.47%   -44.11%     
===========================================
  Files          63        1       -62     
  Lines        9963       23     -9940     
===========================================
- Hits         8726       10     -8716     
+ Misses       1237       13     -1224     
Impacted Files Coverage Δ
src/Material.cc
src/Cylinder.cc
src/Atmosphere.cc
src/Box.cc
src/parser.cc
src/Joint.cc
src/SemanticPose.cc
src/Noise.cc
src/SDFImplPrivate.hh
src/Utils.cc
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1491d72...5329adb. Read the comment docs.

Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about also updating the Load function to load shininess value from SDF?

Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
@ahcorde ahcorde merged commit 0f9b771 into gazebosim:sdf9 Apr 22, 2022
Core development automation moved this from In review to Done Apr 22, 2022
@chapulina chapulina moved this from Done to Highlights in Core development Apr 25, 2022
@j-rivero j-rivero removed this from Highlights in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel Gazebo 1️1️ Dependency of Gazebo classic version 11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants