Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commerce-5141 Update schedule/unschedule procedures for memory scheduler jobs #77

Closed

Conversation

matijapetanjek
Copy link
Collaborator

No description provided.

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@matijapetanjek
Copy link
Collaborator Author

ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 2ba32f018d39b3eaacd32ff6c0fed7cfb806cff7

Sender Branch:

Branch Name: COMMERCE-5141
Branch GIT ID: 32e596c82cacdad91e2209dfb189cb5c26fc72da

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@matijapetanjek
Copy link
Collaborator Author

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:stable - 8 out of 9 jobs passed

❌ ci:test:relevant - 19 out of 22 jobs passed in 5 hours 12 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 2ba32f018d39b3eaacd32ff6c0fed7cfb806cff7

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 8d22a791300569a6c92e7b9152e6ae1c6bdc863a

ci:test:stable - 8 out of 9 jobs PASSED
8 Successful Jobs:
ci:test:relevant - 19 out of 22 jobs PASSED
19 Successful Jobs:
For more details click here.

Failures unique to this pull:


Failures in common with acceptance upstream results at 2ba32f0:
  1. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0
    Job Results:

    353 Tests Passed.
    2 Tests Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #396442
      1. PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
        com.liferay.portal.kernel.exception.NoSuchUserException: No User exists with the key {companyId=56307, defaultUser=true}
        com.liferay.portal.kernel.exception.NoSuchUserException: No User exists with the key {companyId=56307, defaultUser=true}
        	at com.liferay.portal.service.persistence.impl.UserPersistenceImpl.findByC_DU(UserPersistenceImpl.java:4548)
        	at com.liferay.portal.service.impl.UserLocalServiceImpl.loadGetDefaultUser(UserLocalServiceImpl.java:3087)
        	at com.liferay.portal.spring.aop.AopMethodInvocationImpl.proceed(AopMethodInvocationImpl.java:50)
        	at com.liferay.portal.spring.transaction.TransactionInterceptor.invoke(TransactionInterceptor.java:69)
        	at com.liferay.portal.spring.aop.AopMethodInvocationImpl.proceed(AopMethodInvocationImpl.java:57)
        	at com.liferay.portal.spring.aop.AopInvocationHandler.invoke(AopInvocationHandler.java:49)
        	at com.sun.proxy.$Proxy39.loadGetDefaultUser(Unknown Source)
        	at com.liferay.portal.service.impl.UserLocalServiceImpl.getDefaultUser(UserLocalServiceImpl.java:2331)
        	at com.liferay.portal.spring.aop.AopMethodInvocationImpl.proceed(AopMethodInvocationImpl.java:50)
        	at com.liferay.portal.spring.aop.AopInvocationHandler.invoke(AopInvocationHandler.java:49)
        	at com.sun.proxy.$Proxy39.getDefaultUser(Unknown Source)
        	at com.liferay.portal.kernel.service.UserLocalServiceUtil.getDefaultUser(UserLocalServiceUtil.java:1359)
        	at com.liferay.portal.kernel.security.auth.CompanyThreadLocal.setCompanyId(Company...
    2. AXIS_VARIABLE=1,label_exp=!master #396442
      1. PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
        com.liferay.portal.kernel.exception.NoSuchUserException: No User exists with the key {companyId=41301, defaultUser=true}
        com.liferay.portal.kernel.exception.NoSuchUserException: No User exists with the key {companyId=41301, defaultUser=true}
        	at com.liferay.portal.service.persistence.impl.UserPersistenceImpl.findByC_DU(UserPersistenceImpl.java:4548)
        	at com.liferay.portal.service.impl.UserLocalServiceImpl.loadGetDefaultUser(UserLocalServiceImpl.java:3087)
        	at com.liferay.portal.spring.aop.AopMethodInvocationImpl.proceed(AopMethodInvocationImpl.java:50)
        	at com.liferay.portal.spring.transaction.TransactionInterceptor.invoke(TransactionInterceptor.java:69)
        	at com.liferay.portal.spring.aop.AopMethodInvocationImpl.proceed(AopMethodInvocationImpl.java:57)
        	at com.liferay.portal.spring.aop.AopInvocationHandler.invoke(AopInvocationHandler.java:49)
        	at com.sun.proxy.$Proxy39.loadGetDefaultUser(Unknown Source)
        	at com.liferay.portal.service.impl.UserLocalServiceImpl.getDefaultUser(UserLocalServiceImpl.java:2331)
        	at com.liferay.portal.spring.aop.AopMethodInvocationImpl.proceed(AopMethodInvocationImpl.java:50)
        	at com.liferay.portal.spring.aop.AopInvocationHandler.invoke(AopInvocationHandler.java:49)
        	at com.sun.proxy.$Proxy39.getDefaultUser(Unknown Source)
        	at com.liferay.portal.kernel.service.UserLocalServiceUtil.getDefaultUser(UserLocalServiceUtil.java:1359)
        	at com.liferay.portal.kernel.security.auth.CompanyThreadLocal.setCompanyId(Company...

@liferay-continuous-integration
Copy link
Collaborator

@matijapetanjek
Copy link
Collaborator Author

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 21 out of 22 jobs passed in 5 hours 27 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 826c5123ca36f821eba3406147aff60ff3de9ef0

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 8d22a791300569a6c92e7b9152e6ae1c6bdc863a

ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 20 out of 22 jobs PASSED
20 Successful Jobs:
For more details click here.

This pull contains no unique failures.


Failures in common with acceptance upstream results at 826c512:
  1. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0
    Job Results:

    353 Tests Passed.
    2 Tests Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #446603
      1. PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
        com.liferay.portal.kernel.exception.NoSuchUserException: No User exists with the key {companyId=55979, defaultUser=true}
        com.liferay.portal.kernel.exception.NoSuchUserException: No User exists with the key {companyId=55979, defaultUser=true}
        	at com.liferay.portal.service.persistence.impl.UserPersistenceImpl.findByC_DU(UserPersistenceImpl.java:4548)
        	at com.liferay.portal.service.impl.UserLocalServiceImpl.loadGetDefaultUser(UserLocalServiceImpl.java:3087)
        	at com.liferay.portal.spring.aop.AopMethodInvocationImpl.proceed(AopMethodInvocationImpl.java:50)
        	at com.liferay.portal.spring.transaction.TransactionInterceptor.invoke(TransactionInterceptor.java:69)
        	at com.liferay.portal.spring.aop.AopMethodInvocationImpl.proceed(AopMethodInvocationImpl.java:57)
        	at com.liferay.portal.spring.aop.AopInvocationHandler.invoke(AopInvocationHandler.java:49)
        	at com.sun.proxy.$Proxy39.loadGetDefaultUser(Unknown Source)
        	at com.liferay.portal.service.impl.UserLocalServiceImpl.getDefaultUser(UserLocalServiceImpl.java:2331)
        	at com.liferay.portal.spring.aop.AopMethodInvocationImpl.proceed(AopMethodInvocationImpl.java:50)
        	at com.liferay.portal.spring.aop.AopInvocationHandler.invoke(AopInvocationHandler.java:49)
        	at com.sun.proxy.$Proxy39.getDefaultUser(Unknown Source)
        	at com.liferay.portal.kernel.service.UserLocalServiceUtil.getDefaultUser(UserLocalServiceUtil.java:1359)
        	at com.liferay.portal.kernel.security.auth.CompanyThreadLocal.setCompanyId(Company...
    2. AXIS_VARIABLE=1,label_exp=!master #446603
      1. PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
        com.liferay.portal.kernel.scheduler.SchedulerException: Based on configured schedule, the given trigger "DISPATCH_GROUP_0048916.DISPATCH_JOB_0048916" will never fire.
        com.liferay.portal.kernel.scheduler.SchedulerException: Based on configured schedule, the given trigger "DISPATCH_GROUP_0048916.DISPATCH_JOB_0048916" will never fire.
        	at com.liferay.portal.scheduler.quartz.internal.QuartzSchedulerEngine.validateTrigger(QuartzSchedulerEngine.java:557)
        	at com.liferay.portal.kernel.messaging.proxy.ProxyRequest.execute(ProxyRequest.java:82)
        	at com.liferay.portal.kernel.messaging.proxy.ProxyMessageListener.receive(ProxyMessageListener.java:58)
        	at com.liferay.portal.kernel.messaging.InvokerMessageListener.receive(InvokerMessageListener.java:74)
        	at com.liferay.portal.messaging.internal.sender.DirectSynchronousMessageSender.send(DirectSynchronousMessageSender.java:67)
        	at com.liferay.portal.kernel.messaging.proxy.BaseProxyBean.synchronousSend(BaseProxyBean.java:60)
        	at com.liferay.portal.kernel.messaging.proxy.MessagingProxyInvocationHandler.invoke(MessagingProxyInvocationHandler.java:55)
        	at com.sun.proxy.$Proxy246.validateTrigger(Unknown Source)
        	at com.liferay.portal.scheduler.internal.SchedulerEngineHelperImpl.schedule(SchedulerEngineHelperImpl.java:628)
        	at com.liferay.portal.scheduler.internal.SchedulerEngineHelperImpl.schedule(SchedulerEngineHelperImpl.java:650)
        	at com.liferay.dispatch.internal.helper.DispatchTriggerHelper.addSchedu...

@liferay-continuous-integration
Copy link
Collaborator

@igorbeslic
Copy link
Owner

Just started reviewing :)

@igorbeslic
Copy link
Owner

Pull request submitted to liferay-commerce#384. See changes here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants