Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix proc unfolding scope #167

Merged
merged 2 commits into from
Oct 10, 2022
Merged

Fix proc unfolding scope #167

merged 2 commits into from
Oct 10, 2022

Conversation

gr8bit
Copy link
Collaborator

@gr8bit gr8bit commented Oct 8, 2022

Fixes bug where attributes not belonging to the validator were accidentally unfolded. This affected if and unless parameters, when using it like this, for example:

validates :avatar, content_type: ALLOWED_CONTENT_TYPES, size: { less_than: 10.megabytes }, if: -> { attachment_changes['avatar'] }

Fixes #166

@igorkasyanchuk igorkasyanchuk merged commit 1077e86 into igorkasyanchuk:master Oct 10, 2022
@igorkasyanchuk
Copy link
Owner

merged 👍

@gr8bit gr8bit deleted the fix_proc_unfolding branch October 19, 2022 11:24
@gr8bit gr8bit mentioned this pull request Oct 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conditional validation not working
2 participants
@gr8bit @igorkasyanchuk