-
-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix slowness #169
Fix slowness #169
Conversation
We don't need to specify either allowing and rejecting. Fix igorkasyanchuk#127
@sobrinho if I understand correctly, we still have a breaking behavior with this PR as @joshmcarthur pointed out in #127, right? |
@sobrinho this looks like a good solution. I think it worth to merge. But can you please check if we need this method |
Yep, it is a breaking change in terms of not testing the other side of the validator. |
Ok, but I also think the advantages outweigh that. 👍 |
@gr8bit from your side do you approve this PR? |
Yes. 👍 |
Why exactly is specifying both |
I don't recall why I added that but restoring it works just fine. Added a new PR: #173 |
We don't need to specify either allowing and rejecting.
Fix #127