Added home page skeleton #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpereverzev
reviewed
May 25, 2020
| @@ -32,6 +32,8 @@ | |||
| #endif | |||
|
|
|||
| #include "mu4/appshell/appshellmodule.h" | |||
| #include "mu4/scores/scoresmodule.h" | |||
There was a problem hiding this comment.
не знаю насколько актуально в свежих пулл-реквестах, но думаю, что не стоит упоминать номер версии в директории "mu4"
There was a problem hiding this comment.
mu4 временная директория, думаю потом всё её содержимое должно попасть в корень.
Лучше конечно сделать директорию mu3 или old, но пока это трудоёмко сделать
| delegate: ItemDelegate { | ||
| height: 56 | ||
| anchors.left: parent.left | ||
| anchors.right: parent.right |
There was a problem hiding this comment.
можно просто width: parent.width раз без отступов
| } | ||
| } | ||
|
|
||
| Rectangle { |
There was a problem hiding this comment.
а зачем Rectangle с нулевым размером?
а ниже еще и anchors.fill: parent
There was a problem hiding this comment.
Контент в любом Dock контейнере ресайзится по размеру контейнера
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Добаил склет страницы Home
Добавил шаблон cmake для проектов модулей
Добавил скелеты модулей Score и Extensions