[WIP] Notation note input #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue is fixed by adding dummy note events to end of loop before playback, because the sequencer only looks for the last event in the events map before looping back.
…on in metaedit dialog.
Slightly better fix than originally attempted in PR musescore#5890. This time editing is terminated if the main window does not have focus, which means that it is safe to use toolbar buttons that take focus away from the score, such as the buttons for Voices 1 to 4. As with PR musescore#5890, these changes do not allow letter keys to open menu items. That would require substantial changes to the shortcut system as discussed in PR musescore#5890.
Resolves: https://musescore.org/en/node/294643 Those were the main changes made: * Add support for harmonic (only natural for now) * Refactor the musicxml IO to be able to handle the XML modifiers in a generic way * The implicit and explicit values are being flagged properly so that we can handle them correctly
… Crash Free ratio Disable inspector data collection Introduce telemetry data collection enum to control the data we enable and disable for collection.
…usicxml-technical-notation fix #294643: musicxml export technical notation
…ents Disable sending all events to telemetry, but the ones responsible for…
…ast-measure fix #148311 by adding dummy note events to end of loop during playback
fix #101991 Ignore shortcuts in menus
Add reveal in finder (show in explorer) option in metaedit dialog.
Clarify the text for ambitus update range. Add tooltip.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.