Fix error when an absolute path is given #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an absolute path is given (e.g. via `lint-staged`), `node-ignore` was throwing a RangeError `path should be a path.relative()'d string`. see https://github.com/kaelzhang/node-ignore#1-pathname-should-be-a-pathrelatived-pathname This is only a "quick win" to fix this issue. As `prepareFileList` was already returning an `absolute` property based on the cwd, this commit only introduce a new `relative` property, which is also based on the cwd. No new specific test was written for this use case.
DavidAnson
requested changes
Mar 5, 2020
| @@ -110,6 +110,7 @@ function prepareFileList(files, fileExtensions, previousResults) { | |||
| return flatten(files).map(function (file) { | |||
| return { | |||
| original: file, | |||
| relative: path.relative(process.cwd(), file), | |||
There was a problem hiding this comment.
Could you capture the call to cwd in a const outside the map, please?
|
I would love to add tests here, but I think you didn’t because it’s not clear how to do so in a platform-independent manner, right? |
|
I found a way to add tests that should be platform-independent and merged this PR. |
|
Hi @DavidAnson. Sorry I forgot about this PR. Thansk for the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an absolute path is given (e.g. via
lint-staged),node-ignorewas throwing a RangeErrorpath should be a path.relative()'d string.see https://github.com/kaelzhang/node-ignore#1-pathname-should-be-a-pathrelatived-pathname
This is only a "quick win" to fix this issue.
As
prepareFileListwas already returning anabsoluteproperty based on the cwd, this commit only introduce a newrelativeproperty, which is also based on the cwd.No new specific test was written for this use case.
Close #79