Emit errors send Exception objects

igorw · May 10, 2012 · 3007eb7 · 3007eb7
1 parent be42ab5
commit 3007eb7
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/React/Http/RequestHeaderParser.php b/src/React/Http/RequestHeaderParser.php
@@ -14,7 +14,7 @@ class RequestHeaderParser extends EventEmitter
     public function feed($data)
     {
         if (strlen($this->buffer) + strlen($data) > $this->maxSize) {
-            $this->emit('error', array("Maximum header size of {$this->maxSize} exceeded."));
+            $this->emit('error', array(new \OverflowException("Maximum header size of {$this->maxSize} exceeded."), $this));
             return;
         }
 

diff --git a/src/React/Socket/Buffer.php b/src/React/Socket/Buffer.php
@@ -63,13 +63,13 @@ public function handleWrite()
             $sent = fwrite($this->socket, $this->data);
         } catch (\ErrorException $e) {
             $sent = false;
-            $error = $e->getMessage();
+            $error = $e;
         }
 
         restore_error_handler();
 
         if (false === $sent) {
-            $error = $error ?: 'Unable to write to socket';
+            $error = $error ?: new \RuntimeException('Unable to write to socket');
             $this->emit('error', array($error));
             return;
         }

diff --git a/src/React/Socket/Server.php b/src/React/Socket/Server.php
@@ -28,7 +28,7 @@ public function listen($port, $host = '127.0.0.1')
         $this->loop->addReadStream($this->master, function ($master) use ($that) {
             $newSocket = stream_socket_accept($master);
             if (false === $newSocket) {
-                $that->emit('error', array('Error accepting new connection'));
+                $that->emit('error', array(new \RuntimeException('Error accepting new connection')));
                 return;
             }
             $that->handleConnection($newSocket);