Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set default branch to 'develop'? #2

Closed
jankatins opened this issue Apr 12, 2013 · 3 comments
Closed

set default branch to 'develop'? #2

jankatins opened this issue Apr 12, 2013 · 3 comments

Comments

@jankatins
Copy link
Contributor

To see whats going on in igraph one has to set the branch to develop. Would it be possible to set this branch as the default?

https://github.com/blog/421-pick-your-default-branch
http://stackoverflow.com/questions/11334045/how-to-set-the-default-branch-in-github-com

@ntamas
Copy link
Member

ntamas commented Apr 15, 2013

GitHub repositories usually have the "master" branch as the default, especially if they follow the git-flow branching model (which we strongly plan to do). If you want to follow the develop branch, it only takes git checkout master in your local copy to track the development branch instead of the master branch. So, unless Gábor objects, I vote for keeping the master branch as the default.

@gaborcsardi
Copy link
Contributor

We set it to 'master' to avoid people complaining about igraph not working, as the 'develop' branch is often non-functional, sometimes it does not even compile. You can get an RSS feed, or github/email notifications about the commits in the develop branch, if you want.

@ntamas
Copy link
Member

ntamas commented Apr 15, 2013

Oh, the synchronicity.

gaborcsardi added a commit that referenced this issue Dec 10, 2014
ntamas added a commit that referenced this issue Apr 19, 2022
The particular warning that we are trying to fix is as follows:

core/isomorphism/bliss/graph.cc:573:7: runtime error: load of value 59, which is not a valid value for type 'bool'
    #0 0x7f7aa90a0c2a in bliss::TreeNode::TreeNode(bliss::TreeNode const&) core/isomorphism/bliss/graph.cc:573
    #1 0x7f7aa90a0c2a in void __gnu_cxx::new_allocator<bliss::TreeNode>::construct<bliss::TreeNode, bliss::TreeNode const&>(bliss::TreeNode*, bliss::TreeNode const&) /usr/include/c++/11/ext/new_allocator.h:162
    #2 0x7f7aa90a0c2a in void std::allocator_traits<std::allocator<bliss::TreeNode> >::construct<bliss::TreeNode, bliss::TreeNode const&>(std::allocator<bliss::TreeNode>&, bliss::TreeNode*, bliss::TreeNode const&) /usr/include/c++/11/bits/alloc_traits.h:516
    #3 0x7f7aa90a0c2a in void std::vector<bliss::TreeNode, std::allocator<bliss::TreeNode> >::_M_realloc_insert<bliss::TreeNode const&>(__gnu_cxx::__normal_iterator<bliss::TreeNode*, std::vector<bliss::TreeNode, std::allocator<bliss::TreeNode> > >, bliss::TreeNode const&) /usr/include/c++/11/bits/vector.tcc:449
    #4 0x7f7aa903429a in std::vector<bliss::TreeNode, std::allocator<bliss::TreeNode> >::push_back(bliss::TreeNode const&) /usr/include/c++/11/bits/stl_vector.h:1198
    #5 0x7f7aa903429a in bliss::AbstractGraph::search(bool, bliss::Stats&, std::function<void (unsigned int, unsigned int const*)> const&, std::function<bool ()> const&) core/isomorphism/bliss/graph.cc:805
    #6 0x7f7aa9046637 in bliss::AbstractGraph::canonical_form(bliss::Stats&, std::function<void (unsigned int, unsigned int const*)> const&, std::function<bool ()> const&) core/isomorphism/bliss/graph.cc:1759
    #7 0x7f7aa8f8297f in igraph_canonical_permutation core/isomorphism/bliss.cc:250
    #8 0x7f7aa8f87a8f in igraph_isomorphic_bliss core/isomorphism/bliss.cc:501

...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants