Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI MINW32/MINGW64(autoconf): github workflow enhancements #1565

Merged
merged 8 commits into from
Dec 4, 2020

Conversation

jannick0
Copy link
Contributor

@jannick0 jannick0 commented Dec 4, 2020

A mixed commit series in tiny steps covering mostly CI MINGW32/MINGW64 (autoconf):

  • It appears that a github action is only triggered on a branch when the workflow file exists on that branch. So no need to restrict any branch names here.
  • Branches with names starting with github/, travis/ or appveyor/ trigger the mentioned CI only or - as implemented - are ignored by all CIs other than the mentioned one.
  • Fix to EOL issue (Windows).

The implemented name convention differs from the logic suggested in the discussion of #1558. I am open for discussion, of course. Please edit as you may find appropriate.

NB: git prohibits brach names composed as <existing branch name>/<feature> (e.g. a branch name like master/abc is rejected when master already exists).

More details in the commit messages.

TODO: Once this is in, badges could be added to README.md.

Amends 4c1cdb9.

* tests/atlocal.in: enclose substitution of @SED_PIPE_CRLF2LF@ in double
  quotes required by bash to work for multi-char strings.
…r CIs

NB: It appears that Github Workflows are triggered on branches which 'see' the
    workflow file, i.e. the workflow file exists on the branch in question.

* .github/workflows/msys-build.yml:
  - ignore pushes to branches with names starting by 'appveyor/' or
    'travis/'
* .travis.yml:
  - add element branches.except
  - remove trailing white spaces
* appveyor.yml:
   - add element branches.except
* .github/workflows/build-autoconf.yml:
  - renamed from .github/workflows/msys2-build.yml to indicate that
    workflow refers to autoconf build machinery only and to avoid
    confusion with workflow file names on other branches
* .github/workflow/build-autoconf.yml:
  - rename github action name
  - split out step 'Build' into steps 'Run Configuration' and 'Build'
  - make use of conditional step run
  - get git tags for input to versioning string
  - remove invalid configure flag '--with-external-glp'
* .github/workflow/build-autoconf.yml
  - add running testsuite only if build succeeded
* .github/workflow/build-autoconf.yml
  - add step generating artifacts - if available - with config files and
    testsuite dir with detailed failed test information
@ntamas ntamas merged commit 5d6e962 into igraph:master Dec 4, 2020
@ntamas
Copy link
Member

ntamas commented Dec 4, 2020

Thanks a lot!

@jannick0 jannick0 deleted the CI-autoconf-enhancements branch December 4, 2020 09:30
@jannick0
Copy link
Contributor Author

jannick0 commented Dec 4, 2020

One of the two jobs fail because of git fetch --prune --unshallow which might compete with the same of the other job. If this persists, then git fetch --prune --unshallow || true might help.

The same could be added to the develop branch. I am running out of time, so I am wondering if one of you guys could amend the github workflow there. That would be helpful.

@jannick0
Copy link
Contributor Author

jannick0 commented Dec 4, 2020

actions/checkout#400 - feature request to add fetching tags into action/checkout.

@vtraag
Copy link
Member

vtraag commented Dec 4, 2020

@jannick0, not sure if this helps, but in another project I used the following piece for GitHub actions to make sure we have all commits necessary to identify a version from git tags.

    - uses: actions/checkout@v2
      with:
        fetch-depth: 0

@ntamas
Copy link
Member

ntamas commented Dec 4, 2020

Merged this PR into develop and tried to reconcile the changes with CMake. We'll see how it goes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants